Date: Fri, 03 Nov 2006 15:19:48 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: dougb@freebsd.org Cc: freebsd-current@freebsd.org Subject: Re: Panic w/latest sources Message-ID: <20061103.151948.1102530221.imp@bsdimp.com> In-Reply-To: <454BBF4C.3040205@FreeBSD.org> References: <454BBF4C.3040205@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <454BBF4C.3040205@FreeBSD.org>
Doug Barton <dougb@freebsd.org> writes:
: > I have up to the minute -current sources, running on an Intel core
: > 2 duo in i386+SMP. Right after probing the PCI bus (pci0: <ACPI PCI bus>
: > on pcib0) I get a panic. rman_get_start+0x6: movl 0(%eax),%eax
: >
: > GENERIC kernel from the October snapshot works fine.
:
: I'm afraid Warner is on the hook for this one. Reverting this change
: allows me to boot a new kernel with otherwise up to date sources.
:
: Warner, let me know if there is anything I can do to help, test, etc.
Try the latest code. Should be fixed already. There was a use the
res before checking to see if it was NULL bug that I fixed after the
commit you quoted.
Warner
: Doug
:
: -------- Original Message --------
: Subject: cvs commit: src/sys/dev/pci pci.c pci_pci.c pcivar.h
: Date: Mon, 30 Oct 2006 19:18:46 +0000 (UTC)
: From: Warner Losh <imp@FreeBSD.org>
: To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
:
: imp 2006-10-30 19:18:46 UTC
:
: FreeBSD src repository
:
: Modified files:
: sys/dev/pci pci.c pci_pci.c pcivar.h
: Log:
: More fully support 64-bit bars. Prior to this commit, we supported
: only those bars that had addresses assigned by the BIOS and where the
: bridges were properly programmed. Now even unprogrammed ones work.
: This was needed for sun4v. We still only implement up to 2GB memory
: ranges, even for 64-bit bars. PCI standards at least through 2.2 say
: that this is the max (or 1GB is, I only know it is < 32bits).
:
: o Always define pci_addr_t as uint64_t. A pci address is always
: 64-bits,
: but some hosts can't address all of them.
: o Preserve the upper half of the 64-bit word during resource probing.
: o Test to make sure that 64-bit values can fit in a u_long (true on
: some
: platforms, but not others). Don't use those that can't.
: o minor pedantry about data sizes.
: o Better bridge resource reporting in bootverbose case.
: o Minor formatting changes to cope with different data types on
: different
: platforms.
:
: Submitted by: jmg, with many changes by me to fully support 64-bit
: addresses.
:
: Revision Changes Path
: 1.317 +29 -12 src/sys/dev/pci/pci.c
: 1.42 +39 -33 src/sys/dev/pci/pci_pci.c
: 1.72 +1 -13 src/sys/dev/pci/pcivar.h
:
: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci.c.diff?&r1=1.316&r2=1.317&f=h
: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci_pci.c.diff?&r1=1.41&r2=1.42&f=h
: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pcivar.h.diff?&r1=1.71&r2=1.72&f=h
:
:
: --
:
: This .signature sanitized for your protection
:
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061103.151948.1102530221.imp>