Date: Thu, 16 Nov 2017 10:56:24 -0500 From: Allan Jude <allanjude@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316980 - head/contrib/zstd/programs Message-ID: <4fe304eb-eb98-2fcb-f8aa-4f0b433d2209@freebsd.org> In-Reply-To: <20171116090447.sjwtzrwgyuarh7kv@ivaldir.net> References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL%2B0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <20171116090447.sjwtzrwgyuarh7kv@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l5dcWr240hjmPr8r3X35MvwqPHDFxCehu Content-Type: multipart/mixed; boundary="ji1S7R5KVWLFqa4QRDfTSowAaNdnpRwO3"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org>, Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <4fe304eb-eb98-2fcb-f8aa-4f0b433d2209@freebsd.org> Subject: Re: svn commit: r316980 - head/contrib/zstd/programs References: <201704152015.v3FKFiwZ006836@repo.freebsd.org> <CAG6CVpWxxUuT13NL+0LbEDW3N91i4-imsXUBrv1jiTcihs25KQ@mail.gmail.com> <20171116090447.sjwtzrwgyuarh7kv@ivaldir.net> In-Reply-To: <20171116090447.sjwtzrwgyuarh7kv@ivaldir.net> --ji1S7R5KVWLFqa4QRDfTSowAaNdnpRwO3 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2017-11-16 04:04, Baptiste Daroussin wrote: > On Wed, Nov 15, 2017 at 07:38:13PM -0800, Conrad Meyer wrote: >> Please revert this change. >> >> First, it introduces the POLA-violating behavior that zstdcat deletes >> its source files. This is not how zcat/bzcat behaves. >=20 > This is not a POLA-violating behavior, this is a bug! that I introduced= =2E >> >> Second, it introduces a needless behavioral difference between FreeBSD= >> zstd and the rest of the world's zstd. The zstd documentation we ship= >> continues to claim that zstd preserves source files by default, yet >> this change makes that documentation exactly backwards. While we can >> change FreeBSD's documentation to accommodate the change, we can't >> change Google results. >> >=20 > The difference has been made so that zstd follow by default the same be= haviour > has gzip/bzip2/xz so it can be a dropped in replacement. >=20 > The argument about the documentation is however a good one. Let me do f= irst some > tests to ensure restoring the initial behaviour does not break existing= usage in > base >=20 > Best regards, > Bapt >=20 I think in this case, it is safer to surprise the user by NOT deleting a file, than to surprise a user by DELETING a file. If you really want to modify the behaviour (I suggest we don't, and stick closer to upstream zstd), then you'll want to set the 'delete' flag for the specific invocation cases inside zstdcli.c, rather than modifying the default as was done in this commit. I think we can deal with changing the default verbosity level. I think if we want to compromise, we make 2 additional hard links, zzip and zunzip that maintain the gzip like behaviour, since those will not conflict with the documentation that exists in the rest of the world for zstd(1) --=20 Allan Jude --ji1S7R5KVWLFqa4QRDfTSowAaNdnpRwO3-- --l5dcWr240hjmPr8r3X35MvwqPHDFxCehu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJaDbUuAAoJEBmVNT4SmAt+pkQP/0GFptJp8xFsvcxp6I/yRdWd 5fbIp7O/dsldglnlB89FhO/TO0P1QWk8vwsRRkTojXw+cx0FTekouNg6/q9NvLMh GLZB1z8ulKV02NbnxF1SJR8ZHadUnkbymhCEhAW1WiiQeJ2O66DKPC+0mlhYbVWF GcrRXDqCZ19WovipuoJ/GmFEW0+L2r4r44UekVJ5iY65y0n7mwGu7WKrsgqyfQGp Lb1U4MBnMGJh0S0dUNNRjsklPeoGkHjSIAbL5easrPXGkjp7kXVj5BqRv4VDT26f 71k5CQRcJEsQhPFzvqNOfT314zZlutCQJ84O628I9qZefQhpmod6Y8ThnWmaJai1 HmQpfnaqgSpRwwzCr/wuYazW7CmQnrjRgre9wXSNT7TVglDOCG53ZcaxJVIU/7Lm FtfCDJK6MQvGmsBNviKfWm8qp6UFq3vhUQM+sUiUVE7Fg53AmVOuBmCWSF3afM4c 6ezEVoOFP4ZnwBSkDaH956ZUvNgiKnspAvn8vZN6U/w7dh96v8kR8L3CCZykc3an 6yXyJ1v30cV59ytimu9hJrS1SW4cq6uzSrp3tiVC/A61NJB78syEk2hV40ws1ChK Nl3SRWPCJ/WfNumKQpei3AheptsCJFUabjmK/2IqXGFxTp3C5bnRDIqpbVnu5Eb3 9h2xxZFMk4Ipr0sDDjmF =o/mq -----END PGP SIGNATURE----- --l5dcWr240hjmPr8r3X35MvwqPHDFxCehu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4fe304eb-eb98-2fcb-f8aa-4f0b433d2209>