Date: Fri, 11 May 2012 17:03:59 -0700 From: Xin LI <delphij@gmail.com> To: Xin LI <delphij@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r235301 - head/sys/kern Message-ID: <CAGMYy3twRfACSF9rMCwjJOwUBuT_j9N1VLtTeJ5xNO6xhnd2PA@mail.gmail.com> In-Reply-To: <201205112343.q4BNhWh7005829@svn.freebsd.org> References: <201205112343.q4BNhWh7005829@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 11, 2012 at 4:43 PM, Xin LI <delphij@freebsd.org> wrote: > Author: delphij > Date: Fri May 11 23:43:32 2012 > New Revision: 235301 > URL: http://svn.freebsd.org/changeset/base/235301 > > Log: > =C2=A0Revert previous revision, misunderstood the code :( > > Modified: > =C2=A0head/sys/kern/kern_kthread.c > > Modified: head/sys/kern/kern_kthread.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_kthread.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Fri May 11 23= :41:52 2012 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r235300) > +++ head/sys/kern/kern_kthread.c =C2=A0 =C2=A0 =C2=A0 =C2=A0Fri May 11 23= :43:32 2012 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r235301) > @@ -182,7 +182,6 @@ kproc_suspend(struct proc *p, int timo) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return (EINVAL); > =C2=A0 =C2=A0 =C2=A0 =C2=A0} > =C2=A0 =C2=A0 =C2=A0 =C2=A0SIGADDSET(p->p_siglist, SIGSTOP); > - =C2=A0 =C2=A0 =C2=A0 PROC_UNLOCK(p); > =C2=A0 =C2=A0 =C2=A0 =C2=A0wakeup(p); > =C2=A0 =C2=A0 =C2=A0 =C2=A0return msleep(&p->p_siglist, &p->p_mtx, PPAUSE= | PDROP, "suspkp", timo); For the record, p->p_mtx is the mutex used by PROC_[UN]LOCK(), which has to be held while calling msleep(). Cheers, --=20 Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGMYy3twRfACSF9rMCwjJOwUBuT_j9N1VLtTeJ5xNO6xhnd2PA>