Date: Fri, 8 Oct 2010 13:19:59 GMT From: Svatopluk Kraus <onwahe@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/151305: [patch] - CTASSERT(sizeof(struct jmvrec) == JREC_SIZE) Message-ID: <201010081319.o98DJxfP062140@www.freebsd.org> Resent-Message-ID: <201010081320.o98DK3FD047316@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 151305
>Category: kern
>Synopsis: [patch] - CTASSERT(sizeof(struct jmvrec) == JREC_SIZE)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Oct 08 13:20:03 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Svatopluk Kraus
>Release: current
>Organization:
>Environment:
coldfire port
>Description:
A macro CTASSERT() hits in colfire port I work on. It is possibly due to use of GNU GCC compiler -Os option (size optimalization). It hits on struct jmvrec in sys/ufs/ffs/fs.h.
>How-To-Repeat:
>Fix:
I arranged the struct definition (a size of unused field).
Patch attached with submission follows:
Index: sys/ufs/ffs/fs.h
===================================================================
--- sys/ufs/ffs/fs.h (revision 213567)
+++ sys/ufs/ffs/fs.h (working copy)
@@ -696,7 +696,7 @@
uint32_t jm_op;
ino_t jm_ino;
ino_t jm_parent;
- uint16_t jm_unused;
+ uint32_t jm_unused;
off_t jm_oldoff;
off_t jm_newoff;
};
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010081319.o98DJxfP062140>