Date: Wed, 31 Aug 2016 15:22:29 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r305125 - in head: lib/libstand sys/boot/common sys/boot/efi/libefi sys/boot/efi/loader sys/boot/i386/libi386 sys/boot/i386/loader sys/boot/pc98/loader Message-ID: <20160831132229.phrzg3itpgj7iliy@ivaldir.etoilebsd.net> In-Reply-To: <201608311316.u7VDGeCM029352@repo.freebsd.org> References: <201608311316.u7VDGeCM029352@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3uvgvjx4c336ktya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2016 at 01:16:40PM +0000, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Aug 31 13:16:40 2016 > New Revision: 305125 > URL: https://svnweb.freebsd.org/changeset/base/305125 >=20 > Log: > Netboot: allow both tftpfs and nfs in both pxeboot and loader.efi > =20 > Add a new 'netproto' variable which can be set for now to > NET_TFTP or NET_NFS (default to NET_NONE) > =20 > From the dhcp options if one sets the root-path option to: > "ip:path", the loader will consider it is booting over NFS > (meaning same behaviour as the default current behaviour) > =20 > if the dhcp option "tftp server address" is set (option 150) > the loader will consider it is booting over tftpfs, it will then > consider the root-path options with 2 possible case > 1. "path" then the IP of the tftp server will be the one passed by > the option 150, and the files will be retrieved under "path" on the tftp > server > 2. "ip:path" then the IP of the tftp server will be the one passed in > the option "overwritting the IP from the option 150. > =20 > We could not "abuse" the rootpath option in the form or tftp://ip:path = because > this is already used for other purpose by iPXE preventing any chainload= from > iPXE to the FreeBSD loader. > =20 > Given at each open(), the loader loops over all available filesystems a= nd keep > the "best" error, we needed to prevent tftpfs to fallback on nfs and vi= ce versa. > the tftpfs and nfs implementation in libstand now return EINVAL early if > 'netproto' for that purpose. > =20 > Reviewed by: tsoome > Relnotes: yes > Sponsored by: Gandi.net > Differential Revision: https://reviews.freebsd.org/D7628 I forgot to mention a guard was added to libstand's net.h, because it is included multiple times for some loaders Best regards, Bapt --3uvgvjx4c336ktya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXxtoKAAoJEGOJi9zxtz5aomQQAKyADodOuYI19SEUhKY/mBVi 0II7ZsjGA/kAX6d/oDJwhx0+aPrjO9K7RdMF98GfJWQg7chbghowATKq9lUdiZzu fqMlOfJrXFjgSoHyZMBLEisF6YDpTFhLIoQgYJ0dh1K9164ane29mOIbUrvmDWeF 1wOxkW1tGSXFOZVcHUlvyNQT74mA+g4mXFd0ZmHf+s2fe80myUTDsMmSfYPyKk4M p0zcsMKPHe5hxIl7p8mDHxoPVua/QCbLlRNachWEvv7+R0yMQz5PRPdwzQdeLtD/ +VM9+asJMLh+5Z3fQYEFn4jBONTy3S+P0EUfYpyGyPFEt8EorKnonBno2huMACTT kOBleVvxLhFv+8m4JhrtHALAbqmXwXTqnYVTkXZyIbohfDYXHcmC6DmGXN7FridG xeoGv4X3l7bDVaXkYXyMaU2eHsHo5yA45mJCyvDxrq3J7WzDYUmvQqI47W+VwZPF DWTvHg2S8nTWxb1bPamJu/eVDtPxI6WUAwpwfXdESmJqCJEp90avsJg/Xca881QL mZJpd3ZRj6P03D6ZbUB7eigKcxRsJ3ZiEGANldGZFGhqq/ph+uAxvmlHllxo5dJx ILUi9rPdiOAmLixtPS78j5tkybWAfKc4udBGXqh+QVPfOxQEgaxrvoCZIsXtH930 AQyffqIIJmzx7NJGJIrz =cT4t -----END PGP SIGNATURE----- --3uvgvjx4c336ktya--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160831132229.phrzg3itpgj7iliy>