Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Sep 2023 02:10:32 GMT
From:      Doug Moore <dougm@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a4c7a3f7f56a - stable/14 - powerpc pmap: initialize kernel pmap radix trie
Message-ID:  <202309200210.38K2AWj7063957@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by dougm:

URL: https://cgit.FreeBSD.org/src/commit/?id=a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae

commit a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae
Author:     Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2023-09-13 18:17:57 +0000
Commit:     Doug Moore <dougm@FreeBSD.org>
CommitDate: 2023-09-20 02:09:37 +0000

    powerpc pmap: initialize kernel pmap radix trie
    
    Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie
    implementation and made it necessary that radix tries be initialized
    with vm_radix_init. @dbaio reports that in some configurations, there
    is a powerpc boot panic and that this commit introduced the
    problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is
    initialized by zeroing all its fields.
    
    Add a call to vm_radix_init to properly initialize
    kernel_pmap->pm_radix.
    
    Reported by:    dbaio
    Reviewed by:    alc, jhibbits
    Fixes:  2d2bcba7ba drop NULL check from radix trie search
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D41846
    
    (cherry picked from commit 8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4)
---
 sys/powerpc/aim/mmu_radix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/powerpc/aim/mmu_radix.c b/sys/powerpc/aim/mmu_radix.c
index 32d08d2d7026..b904978e042c 100644
--- a/sys/powerpc/aim/mmu_radix.c
+++ b/sys/powerpc/aim/mmu_radix.c
@@ -1843,6 +1843,7 @@ mmu_radix_setup_pagetables(vm_size_t hwphyssz)
 
 	bzero(kernel_pmap, sizeof(struct pmap));
 	PMAP_LOCK_INIT(kernel_pmap);
+	vm_radix_init(&kernel_pmap->pm_radix);
 
 	ptpages = allocpages(3);
 	l1phys = moea64_bootstrap_alloc(RADIX_PGD_SIZE, RADIX_PGD_SIZE);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202309200210.38K2AWj7063957>