Date: Thu, 12 Jan 2012 14:59:11 -0600 From: Dan McGregor <danismostlikely@gmail.com> To: freebsd-current@freebsd.org Subject: ctlstat not building with clang Message-ID: <CACS%2B7ZT5Mi=v41cpE9ZP0hjiHA1THwZFn-jZfTqHL1O4N-8beg@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--f46d0442829c202fe804b65b059a
Content-Type: text/plain; charset=ISO-8859-1
Building world with clang now (as of r229997) no longer compiles because
ctlstat was imported into the tree. The error is:
clang -O2 -pipe -I/usr/src/usr.bin/ctlstat/../../sys -std=gnu99
-fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
-Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow
-Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs
-Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c
/usr/src/usr.bin/ctlstat/ctlstat.c
/usr/src/usr.bin/ctlstat/ctlstat.c:149:35: error: format string is not a
string literal (potentially insecure)
[-Werror,-Wformat-security]
fprintf(error ? stderr : stdout, ctlstat_usage);
^~~~~~~~~~~~~
1 error generated.
*** Error code 1
Stop in /usr/src/usr.bin/ctlstat
How do people feel about the attached patch that turns a call to fprintf to
fputs?
--f46d0442829c202fe804b65b059a
Content-Type: text/x-diff; charset=US-ASCII; name="ctlstat.patch"
Content-Disposition: attachment; filename="ctlstat.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gxc9edo40
SW5kZXg6IGN0bHN0YXQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjdGxzdGF0LmMgICAocmV2aXNpb24gMjMw
MDI2KQorKysgY3Rsc3RhdC5jICAgKHdvcmtpbmcgY29weSkKQEAgLTE0Niw3ICsxNDYsNyBAQAog
c3RhdGljIHZvaWQKIHVzYWdlKGludCBlcnJvcikKIHsKLSAgICAgICBmcHJpbnRmKGVycm9yID8g
c3RkZXJyIDogc3Rkb3V0LCBjdGxzdGF0X3VzYWdlKTsKKyAgICAgICBmcHV0cyhjdGxzdGF0X3Vz
YWdlLCBlcnJvciA/IHN0ZGVyciA6IHN0ZG91dCk7CiB9CiAKIHN0YXRpYyBpbnQK
--f46d0442829c202fe804b65b059a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACS%2B7ZT5Mi=v41cpE9ZP0hjiHA1THwZFn-jZfTqHL1O4N-8beg>