Date: Sat, 26 Aug 2006 05:52:17 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Ian FREISLICH <if@hetzner.co.za>, freebsd-current@FreeBSD.org, Andrew Thompson <thompsa@FreeBSD.org>, John Baldwin <jhb@FreeBSD.org> Subject: Re: 802.1Q vlan performance. [PATCH] Message-ID: <20060826055028.A43127@fledge.watson.org> In-Reply-To: <20060825145632.GY76666@cell.sick.ru> References: <E1GGYM0-000CVd-1K@hetzner.co.za> <E1GGYY5-000CYz-Ow@hetzner.co.za> <20060825101140.GV76666@FreeBSD.org> <200608251031.34081.jhb@freebsd.org> <20060825145632.GY76666@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 25 Aug 2006, Gleb Smirnoff wrote: > On Fri, Aug 25, 2006 at 10:31:33AM -0400, John Baldwin wrote: > J> > I> +++ /usr/src/sys/conf/NOTES 25 Aug 2006 10:03:18 -0000 > J> > I> @@ -646,6 +646,7 @@ > J> > I> # > J> > I> device ether #Generic Ethernet > J> > I> device vlan #VLAN support (needs miibus) > J> > I> +options VLAN_ARRAY #Lookup table for trunk interface > J> > I> device wlan #802.11 support > J> > I> device wlan_wep #802.11 WEP support > J> > I> device wlan_ccmp #802.11 CCMP support > J> > > J> > I'd prefer not to put it into NOTES. When enabled, less code will > J> > be covered by LINT. > J> > J> Bah, GENERIC will cover it then. All options should be in NOTES. If > J> an option removes code and it's enabled in GENERIC, then you should put > J> it in NOTES but comment it out. > > But "device vlan" isn't in GENERIC. Only for historical reasons -- at the recent devsummit, I argued that if_vlan should, in fact, be part of our generic ethernet support code, as vlans have become an expected ethernet link layer feature. I also argued that tigher integration of vlan support into ethernet would help avoid some of the trickier issues in keeping vlan interfaces synchronized to the set of ethernet interfaces, as well as avoiding the mbuf tag overhead, etc. I have some hope of looking into this once if_startmbuf is off the ground. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060826055028.A43127>