Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Apr 2005 14:10:39 -0400 (EDT)
From:      Daniel Eischen <deischen@freebsd.org>
To:        Hajimu UMEMOTO <ume@freebsd.org>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/lib/libc/net getproto.c getprotoent.c         getprotoname.c netdb_private.h
Message-ID:  <Pine.GSO.4.43.0504191402500.6115-100000@sea.ntplx.net>
In-Reply-To: <200504191441.j3JEfD8K003270@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Apr 2005, Hajimu UMEMOTO wrote:

> ume         2005-04-19 14:41:13 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     lib/libc/net         getproto.c getprotoent.c getprotoname.c
>                          netdb_private.h
>   Log:
>   - add getproto{byname,bynumber,ent}_r for internal use within libc.
>   - make getproto{byname,bynumber,ent} thread-safe.

Stop polluting the namespace.  If the externally visible functions
you add are not in a standard and are only for use within libc,
they need to be prefixed with "_" or "__".  I haven't paid attention
to your other commits in libc, but please go back and fix other
occurrences if there are any.  Or make them static if they can
be.

-- 
DE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.43.0504191402500.6115-100000>