Date: Thu, 11 Jul 2019 00:48:38 -0400 From: Randall Stewart <rrs@netflix.com> To: John Baldwin <jhb@freebsd.org> Cc: Randall Ray Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys Message-ID: <7695E2FC-406D-46CE-88F2-0690B9AAA36D@netflix.com> In-Reply-To: <4cdc824e-7e71-731d-50d4-c3f6231f9858@FreeBSD.org> References: <201907102040.x6AKeern006731@repo.freebsd.org> <4cdc824e-7e71-731d-50d4-c3f6231f9858@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John: Thanks for the suggestions.. I have committed changes to the two nits. As to M_PROTO1, I see that in the NF world we have removed M_PROTO12 and moved the M_PROTO=E2=80=99s up 1 i.e. M_PROTO1 =3D=3D = 0x2000 So for now it is safe, since the M_TSTMP_LRO is not yet used.. but in my up and coming commits I will have to address this i.e. either do the same thing or just make it use M_PROTO12. There are a couple of places M_PROTO1 is used on the receive path so that would not work there :o After I get the DSACK fixes in my next change to get BBR in will be the LRO work=E2=80=A6 So maybe I should just settle on using M_PROTO12 for that=20 what do you think? R > On Jul 10, 2019, at 7:28 PM, John Baldwin <jhb@freebsd.org> wrote: >=20 > On 7/10/19 1:40 PM, Randall Stewart wrote: >> Author: rrs >> Date: Wed Jul 10 20:40:39 2019 >> New Revision: 349893 >> URL: https://svnweb.freebsd.org/changeset/base/349893 >>=20 >> Log: >> This commit updates rack to what is basically being used at NF as >> well as sets in some of the groundwork for committing BBR. The >> hpts system is updated as well as some other needed utilities >> for the entrance of BBR. This is actually part 1 of 3 more >> needed commits which will finally complete with BBRv1 being >> added as a new tcp stack. >>=20 >> Sponsored by: Netflix Inc. >> Differential Revision: https://reviews.freebsd.org/D20834 >=20 > Is it safe for M_TSTMP_LRO to conflict with M_PROTO1? >=20 > Also, it seems you changed the copyright range on rack.c from > 2016-2019 to just 2016 which I suspect is an accident. >=20 > I would suggest using #error here: >=20 > #ifndef TCPHPTS > fatal error missing option TCPHSTS in the build; > #endif >=20 > --=20 > John Baldwin ------ Randall Stewart rrs@netflix.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7695E2FC-406D-46CE-88F2-0690B9AAA36D>