Date: Sat, 24 May 2008 19:35:45 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Boris Samorodov <bsam@ipt.ru> Cc: ports@freebsd.org, emulation@FreeBSD.org, Ganael LAPLANCHE <ganael.laplanche@martymac.com> Subject: Re: USE_LINUX_RPM and PORTDOCS Message-ID: <20080524193545.0167e8a4@deskjail> In-Reply-To: <15111974@ipt.ru> References: <20080524073145.M76509@martymac.com> <07923414@ipt.ru> <20080524150909.M12444@martymac.com> <20080524160433.M17651@martymac.com> <15111974@ipt.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Boris Samorodov <bsam@ipt.ru> (Sat, 24 May 2008 20:49:29 +0400):
> On Sat, 24 May 2008 18:05:42 +0200 (CEST) Ganael LAPLANCHE wrote:
> > On Sat, 24 May 2008 17:27:04 +0200 (CEST), Ganael LAPLANCHE wrote
> > > On Sat, 24 May 2008 13:04:57 +0400, Boris Samorodov wrote
> > >
> > > > I'd suggest another option. What about fixing bsd.linux-rpm.mk? Ex.,
> > > > one may introduce, say, a pre-install target (or even do it at the
> > > > very beginning of a do-install stage) and conditionally delete
> > > > unneeded files from WRKDIR (so they won't get installed at do-install
> > > > stage).
> > >
> > > Thanks for your answer :)
> > >
> > > Of course, fixing bsd.linux-rpm.mk would be the best option !
> > >
> > > Your idea is good, but PORTDOCS would not be useable for that purpose.
> > > It cannot be used to identify files to delete because it is relative
> > > to the destination target (DOCSDIR), not to WRKDIR or WRKSRC.
>
> > Wait... DOCSDIR_REL (relative to PREFIX) is derived from DOCSDIR and *may* be
> > also always relative to WRKDIR for linux RPMs, since RPM installation is just a
> > copy of a tree structure which is relative to PREFIX. So maybe I was wrong here.
> > Anyway, if I add that to my archivers/linux-par2cmdline port's Makefile :
>
> > .if defined(NOPORTDOCS)
> > post-extract:
> > .for x in ${PORTDOCS}
> > @${RM} ${WRKDIR}/${DOCSDIR_REL}/${x}
> > .endfor
> > @${RMDIR} ${WRKDIR}/${DOCSDIR_REL}/
> > .endif
>
> > It works :) So I think I'll stick to that solution at the moment.
>
> Great, but I'd say that it should be done a little bit later (may be
> at pre-install stage). "Extract" stage according to bsd.ports.mk
> "Unpacks ${DISTFILES} into ${WRKDIR}".
Removing unwanted stuff in post-extract is not uncommon. I don't think
a patch for linux-rpm.mk with something like this would be a bad
solution.
Bye,
Alexander.
--
Cats, no less liquid than their shadows, offer no angles to the wind.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080524193545.0167e8a4>