Date: Thu, 28 May 2020 19:57:49 +1000 From: Peter Jeremy <peter@rulingia.com> To: Chuck Silvers <chs@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r361491 - in head/sys: geom kern sys ufs/ffs ufs/ufs Message-ID: <20200528095749.GA91775@server.rulingia.com> In-Reply-To: <202005252347.04PNlWnm061022@repo.freebsd.org> References: <202005252347.04PNlWnm061022@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020-May-25 23:47:32 +0000, Chuck Silvers <chs@FreeBSD.org> wrote: >Author: chs >Date: Mon May 25 23:47:31 2020 >New Revision: 361491 >URL: https://svnweb.freebsd.org/changeset/base/361491 > >Log: > This commit enables a UFS filesystem to do a forcible unmount when > the underlying media fails or becomes inaccessible. For example > when a USB flash memory card hosting a UFS filesystem is unplugged. This breaks the build when FFS is not built into the kernel but GEOM is (eg for a ZFS-only system). Specifically, ffs_subr.c is marked "optional ffs | geom_label" and this commit added a dependency on M_UFSMNT (defined in sys/ufs/ufs/ufs_vfsops.c) to ffs_subr.c. The geom_label dependency exists because sys/geom/label/g_label_ufs.c relies on ffs_sbget() (defined in ffs_subr.c) to taste UFS partitions. I'm not sure of the best fix here - ideally, the new functions this commit adds to ffs_subr.c would be moved to a different file (though it's not immediately clear which file that would be. --=20 Peter Jeremy --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE2M6l8vfIeOACl4uUHZIUommfjLIFAl7PixdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQ4 Q0VBNUYyRjdDODc4RTAwMjk3OEI5NDFEOTIxNEEyNjk5RjhDQjIACgkQHZIUommf jLLbvxAAisMxkPQWKFZhPc6uDwMKufDK+3GqNS9UHqcgDuTOcbh65akGyXa5hahS Nlb8O1l35lTPukp4uTKj1j7boSHy1zPyOS64WSEW2AxwlSW3f7gtPQ0j9LyhxkAe HmgxRZuS3MEbEAbHzbin5GyrnsAlEZenOnZqi8r5dRuYdM5gBsErfgHSb7LZVERE ywL60AAj6lnoPUPwqjhWanMt78J/rDklt4ErunEhbt9Gs6GJ4ti0WrCZu7SFeGZy 3HaT4cx6mZE9T0jrQ4t8xF0JXTXmqE3zi0sYsWPVxsw099VUJDTrTOyvBhCpKTna yfJoElpA0SumUVWLvViJSF9Mkcl52DCao7GejkHPGDJppt5qQMueB59LvvODLgTg dJLOCYD/deYvF6rGIq9bxG9I1Hz1kgyjniT1KXbpCBG3MmS33yo+PYs/9eA/LaeZ HsPcoWTHH59KWCvwny0dpx2v7pTkuE2hZlayHOObuUpWFDikSC2olBhW7mlr66R1 STr6agTvLN4pfb3gddaLI0DLtFcn03SoedIom8fC1ZV0ZEYSP040uVyQbR89JJ/s QQqyLgVahPrJfut+1KIEI4oM9iRhgtpFW662JVXlAF/XltnGiyJGsgffVqiZkVOP zcM3JbjL+s4NBuD5th6L5AedqJNWIiBUY5nj319DqH7kpI/RgVk= =oT0a -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200528095749.GA91775>