Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Jan 2025 18:17:48 GMT
From:      Olivier Certner <olce@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 213406054e46 - stable/13 - atomics: Constify loads: Remove now superfluous uses of DECONST()
Message-ID:  <202501271817.50RIHmYv092402@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=213406054e46b50d5df6d28b01a0a3410132b322

commit 213406054e46b50d5df6d28b01a0a3410132b322
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2025-01-20 14:28:37 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2025-01-27 18:17:17 +0000

    atomics: Constify loads: Remove now superfluous uses of DECONST()
    
    No functional change (intended).
    
    Reviewed by:    kib
    MFC after:      4 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D48497
    
    (cherry picked from commit 9b7157c690723279d448fc7ea9c1f9374ad4511a)
    
    During MFC, the change to:
    'sys/compat/linuxkpi/common/include/linux/seqlock.h'
    was elided as lkpi_seqprop_sequence() has never been MFCed to stable/13.
---
 sys/sys/atomic_san.h | 3 +--
 sys/sys/seqc.h       | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/sys/sys/atomic_san.h b/sys/sys/atomic_san.h
index 06c6c98ec8a8..9a82ff6762c6 100644
--- a/sys/sys/atomic_san.h
+++ b/sys/sys/atomic_san.h
@@ -266,8 +266,7 @@ ATOMIC_SAN_THREAD_FENCE(SAN_INTERCEPTOR_PREFIX);
 #define	atomic_fcmpset_rel_ptr		ATOMIC_SAN(fcmpset_rel_ptr)
 #define	atomic_fetchadd_ptr		ATOMIC_SAN(fetchadd_ptr)
 #define	atomic_load_ptr(x)						\
-	((__typeof(*x))ATOMIC_SAN(load_ptr)(				\
-	    __DECONST(volatile uintptr_t *, (x))))
+	((__typeof(*x))ATOMIC_SAN(load_ptr)((const volatile uintptr_t *)(x)))
 #define	atomic_load_acq_ptr		ATOMIC_SAN(load_acq_ptr)
 #define	atomic_load_consume_ptr(x)					\
 	((__typeof(*x))atomic_load_acq_ptr((const volatile uintptr_t *)(x)))
diff --git a/sys/sys/seqc.h b/sys/sys/seqc.h
index 3f1c4efa7252..a0c030cecfc7 100644
--- a/sys/sys/seqc.h
+++ b/sys/sys/seqc.h
@@ -78,14 +78,14 @@ static __inline seqc_t
 seqc_read_any(const seqc_t *seqcp)
 {
 
-	return (atomic_load_acq_int(__DECONST(seqc_t *, seqcp)));
+	return (atomic_load_acq_int(seqcp));
 }
 
 static __inline seqc_t
 seqc_read_notmodify(const seqc_t *seqcp)
 {
 
-	return (atomic_load_acq_int(__DECONST(seqc_t *, seqcp)) & ~SEQC_MOD);
+	return (atomic_load_acq_int(seqcp) & ~SEQC_MOD);
 }
 
 static __inline seqc_t



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202501271817.50RIHmYv092402>