Date: Wed, 11 Jan 2017 23:36:55 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: Ian Lepore <ian@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r311929 - head/sys/boot/common Message-ID: <0ADFDAAC-3858-49B1-BB37-E179D55AF6CE@FreeBSD.org> In-Reply-To: <CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg@mail.gmail.com> References: <201701111847.v0BIl0Mg013954@repo.freebsd.org> <CAGHfRMBy7KPP=vLjEpyfRuf_u4S%2B2mO_W3US9WodMf=ckRJKBQ@mail.gmail.com> <1484170956.86335.17.camel@freebsd.org> <8EF36240-8CD0-449E-AA9C-EFFB7BF0C111@FreeBSD.org> <CAGHfRMBGY=SUHLoUB8qLv2pFXNkFDoDdHW2Xqu97xgba6pY0Yg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 11 Jan 2017, at 23:32, Ngie Cooper <yaneurabeya@gmail.com> wrote: > > On Wed, Jan 11, 2017 at 2:10 PM, Dimitry Andric <dim@freebsd.org> wrote: > > ... > >> The line: >> >> extern int errno; >> >> expanded to: >> >> extern int (* __error()); >> >> which is a declaration of an external function pointer called __error >> (albeit with an empty parameter list). Since nobody actually refers to >> this symbol in libstand, there are no later complaints. >> >> Interestingly, reloc_elf.c does not use errno at all, so I have no idea >> why the include was originally added. > > This is why: > > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 221) #else > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 222) return (EOPNOTSUPP); > 95dd728f5ca86 (iedowse 2004-08-28 23:03:05 +0000 223) #endif > > You probably just broke tinderbox on non-x86/-powerpc. Not very likely, since <stand.h> includes <sys/errno.h>. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlh2s44ACgkQsF6jCi4glqOlvACgz3TmtZNnUB6yjD8oiithWfpX aBEAoNSklFcZWVQLRQnK5jPYmMTSgfuK =W3s1 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0ADFDAAC-3858-49B1-BB37-E179D55AF6CE>