Date: Tue, 05 May 2026 01:21:48 +0000
From: bugzilla-noreply@freebsd.org
To: pkgbase@FreeBSD.org
Subject: [Bug 294966] pkgbase ${SRC}/release/release.sh generic build failing in create-sets-packages
Message-ID: <bug-294966-36141-X6KYQEzQbt@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-294966-36141@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294966 --- Comment #15 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=8e8d87856241f69c277dc5fab48c5c66312475d6 commit 8e8d87856241f69c277dc5fab48c5c66312475d6 Author: Lexi Winter <ivy@FreeBSD.org> AuthorDate: 2026-05-05 00:31:20 +0000 Commit: Lexi Winter <ivy@FreeBSD.org> CommitDate: 2026-05-05 00:32:34 +0000 packages: Make create-sets.sh more robust during release Commit d1c176fedfc9 made create-sets.sh exit when it encounters an error, instead of creating an empty repository. However, this turns out to cause some issues: 1. A package not having any sets is considered an error, but during the release build, we stuff a 'pkg' package into the repository which doesn't have any sets, which causes a failure. Avoid this by simply ignoring the pkg package. 2. No error was printed in this case, which made the problem hard to diagnose. Add an explicit error message. 3. A similar problem occurred running on a repository which already contained sets, which is not usually done during the build, but is not necessarly an inappropriate thing to do. Fix this one by ignoring set packages when looking for sets. While here, fix another issue that might cause packages to be wrongly skipped if the path to the repository contains a '-' character, since we didn't strip the path before testing the package name. PR: 294966 Fixes: d1c176fedfc9 ("packages: Make create-sets.sh more robust") MFC after: 2 weeks Reported by: Alastair Hogge <agh@riseup.net> Reviewed by: emaste Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D56792 release/packages/create-sets.sh | 52 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 4 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-294966-36141-X6KYQEzQbt>