Date: Sat, 29 Jan 2005 18:27:17 +0100 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: Alexander Leidinger <Alexander@leidinger.net> Subject: Re: We have a lot of duplicated code in the kernel Message-ID: <200501291827.27506.max@love2party.net> In-Reply-To: <20050129161022.0de822fe@Magellan.Leidinger.net> References: <20050129161022.0de822fe@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2287346.ARQDyld8Ih Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 29 January 2005 16:10, Alexander Leidinger wrote: > Hi, > > http://www.leidinger.net/FreeBSD/simian-20-sys-20050129.log (253k) > contains a log of duplicated code in /sys (-current as of today). The > file starts with files with 20 consecutive lines of duplicated code and > ends with two files which share 1108 lines of code. > > If I let the program detect 6 consecutive lines of duplicated code, it > is also able to detect possible code reuse in the same file, but it also > prints a lot of "noise" then. > > I've filtered the list for some false positives (twa_fwimg, trlld?m, > if_patm_rtables), if someone else notices some more files please tell me > about them and I add them to the filter. As a first step we might want to concentrate on stuff outside of the MD cod= e. =20 It's understood that i386 and amd64 share quite a bit of code e.g. I'm not= =20 sure that these cases are easy to fix without major revise of the MD parts = of=20 the build infrastructure - what doesn't mean that we shouldn't look at it i= n=20 the long run. Could you regenerate the list w/o the MD code, as a first step? This might= =20 turn up a couple of "easy to fix" cases of shared code. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2287346.ARQDyld8Ih Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD4DBQBB+8d/XyyEoT62BG0RAgoeAJ0YsGr4sJVju+NIkdCbdwfkiQN5iQCYhlEV M7y0jEBJwFmArn42d2IBUg== =PE0d -----END PGP SIGNATURE----- --nextPart2287346.ARQDyld8Ih--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501291827.27506.max>