Date: Thu, 19 Oct 2023 16:56:23 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h Message-ID: <AC90FDA2-1F8B-4984-9BCC-140D041BD729@FreeBSD.org> In-Reply-To: <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org> <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 Oct 2023, at 16:41, Jessica Clarke wrote: > On 19 Oct 2023, at 15:20, Kristof Provost <kp@FreeBSD.org> wrote: >> >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc6c= d830b0bc6b815e8c4 >> >> commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 >> Author: Kristof Provost <kp@FreeBSD.org> >> AuthorDate: 2023-10-19 10:06:29 +0000 >> Commit: Kristof Provost <kp@FreeBSD.org> >> CommitDate: 2023-10-19 14:19:39 +0000 >> >> pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >> >> When userspace includes pfvar.h it doesn't get the kernel's COMPAT_= * >> defines, so we end up not having required symbols in userspace. Thi= s >> caused the libpfctl port to fail to build. >> >> libpfctl will be updated to use the new netlink-based state export = code >> soon, which will also fix thix build issue. >> >> Sponsored by: Rubicon Communications, LLC ("Netgate") > > That=E2=80=99s normally a feature to stop userspace using deprecated th= ings. > Will you be reverting this once libpfctl is fixed? One could also hack > libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that=E2=80= =99s > what was done for kbdcontrol to allow it to run on old kernels). > I wasn=E2=80=99t planning on that, no. The libpfctl port fix should land = soon, but I figured that it=E2=80=99d be better to keep the definitions, = because userspace doesn=E2=80=99t know if the kernel is built with or wit= hout COMPAT_FREEBSD14. I=E2=80=99m open to being persuaded that that=E2=80=99s a bad idea though= =2E Long-term (i.e. by freebsd 16) the plan is for all of these ioctls to go = away (so the code for them will stay in 15, but not be in 16), but that d= oes depend on me doing a fair bit of work before then. Best regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC90FDA2-1F8B-4984-9BCC-140D041BD729>