Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Mar 2026 08:33:37 +0000
From:      Roger Pau =?utf-8?Q?Monn=C3=A9?= <royger@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 1491fe8f864a - main - uart/pci: support 16550A PCI serial devices
Message-ID:  <69c640e1.1fc2b.4542bc24@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by royger:

URL: https://cgit.FreeBSD.org/src/commit/?id=1491fe8f864af5af37e83f1d12459905fb6097fd

commit 1491fe8f864af5af37e83f1d12459905fb6097fd
Author:     Roger Pau Monné <royger@FreeBSD.org>
AuthorDate: 2026-03-26 10:01:57 +0000
Commit:     Roger Pau Monné <royger@FreeBSD.org>
CommitDate: 2026-03-27 08:26:32 +0000

    uart/pci: support 16550A PCI serial devices
    
    Expand the current check to also attach the ns8250 driver to devices
    reporting as 16550A.  This has been tested to work on a real device.
    
    From an inspection of the code in the ns8250 driver it seems like it should
    support up to 16950A devices, but I don't have hardware to ensure that,
    hence be conservative with the change.
    
    MFC: 2 weeks
    Reviewed by: imp
    Differential revision: https://reviews.freebsd.org/D56095
---
 sys/dev/uart/uart_bus_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/uart/uart_bus_pci.c b/sys/dev/uart/uart_bus_pci.c
index 22af8ee8663c..7087958cbfa9 100644
--- a/sys/dev/uart/uart_bus_pci.c
+++ b/sys/dev/uart/uart_bus_pci.c
@@ -297,7 +297,7 @@ uart_pci_probe(device_t dev)
 	}
 	if (pci_get_class(dev) == PCIC_SIMPLECOMM &&
 	    pci_get_subclass(dev) == PCIS_SIMPLECOMM_UART &&
-	    pci_get_progif(dev) < PCIP_SIMPLECOMM_UART_16550A) {
+	    pci_get_progif(dev) <= PCIP_SIMPLECOMM_UART_16550A) {
 		/* XXX rclk what to do */
 		id = &cid;
 		sc->sc_class = &uart_ns8250_class;


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69c640e1.1fc2b.4542bc24>