Date: Sun, 11 Jun 2017 13:54:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Wen Heping <wen@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r443389 - in head/audio/shairport: . files Message-ID: <20170611135424.GB15068@FreeBSD.org> In-Reply-To: <201706111346.v5BDkflQ008975@repo.freebsd.org> References: <201706111346.v5BDkflQ008975@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 11, 2017 at 01:46:41PM +0000, Wen Heping wrote: > New Revision: 443389 > URL: https://svnweb.freebsd.org/changeset/ports/443389 > > Log: > - Update to 1.1.1 > > PR: 194153 > Submitted by: swills@ > Approved by: maintainer(timeout, > 2 years) It would be nice to provide more elaborate commit message. > ... > -RUN_DEPENDS= p5-MIME-Base64>=0:converters/p5-MIME-Base64 \ > - p5-Getopt-Long>=0:devel/p5-Getopt-Long \ > - p5-URI>=0:net/p5-URI \ > - p5-Crypt-OpenSSL-RSA>=0:security/p5-Crypt-OpenSSL-RSA \ > - p5-Digest-MD5>=0:security/p5-Digest-MD5 \ > - p5-HTTP-Message>=0:www/p5-HTTP-Message \ > - avahi-publish-service:net/avahi-app > +RUN_DEPENDS= avahi-publish-service:net/avahi-app So why those p5-* deps are no longer needed? > +do-configure: > + cd ${WRKSRC} ; ./configure What's wrong with our default configure target? > + cd ${WRKSRC} ; ${GMAKE} PREFIX=${STAGEDIR}${PREFIX} install I believe MAKE_CMD should've been used here instead; also ``-C ${WRKSRC}'' would've saved you the trouble of explicit chdir. Then again: what was wrong with our default install target which essentially does the same? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170611135424.GB15068>