Date: Fri, 27 Apr 2018 15:19:06 -0700 From: John Baldwin <jhb@freebsd.org> To: arch@freebsd.org Subject: LIBC_SCCS Message-ID: <1711113.VelFtdTVS7@ralph.baldwin.cx>
next in thread | raw e-mail | index | archive | help
I suspect no one cares, but for whatever reason our current handling of the LIBC_SCCS macro in some of our libraries annoys me. In theory it seems like LIBC_SCCS's purpose is to control whether or not old SCCS IDs from Berkeley are included in libc's sources when libc is built. (Similar to how macros control the behavior of __FBSDID().) However, we use an odd construct in the tree. First, we define LIBC_SCCS by default in the CFLAGS of various libraries (libkvm, libutil, libthr, libc, etc.) which in theory would enable the IDs, but then we explicitly wrap them in #if 0, e.g.: #if defined(LIBC_SCCS) && !defined(lint) #if 0 static char sccsid[] = "@(#)kvm_hp300.c 8.1 (Berkeley) 6/4/93"; #endif #endif /* LIBC_SCCS and not lint */ I'd rather that we make LIBC_SCCS actually work by removing the #if 0 (and perhaps the lint baggage) but then remove it from the default CFLAGS to preserve the existing behavior by default. Does anyone else care if I do this? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1711113.VelFtdTVS7>