Date: Sat, 21 Oct 2017 01:10:31 -0700 From: Ryan Libby <rlibby@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Pedro Giffuni <pfg@freebsd.org>, benno@freebsd.org Subject: Re: svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src Message-ID: <CAHgpiFwhGsW31jr_qQgx7XZWHiCjkXeynWraH6hSNc3CrzTLMw@mail.gmail.com> In-Reply-To: <401F7CFC-1381-4F60-92DE-5771566CD992@gmail.com> References: <201710210723.v9L7Nj6W016491@repo.freebsd.org> <401F7CFC-1381-4F60-92DE-5771566CD992@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 21, 2017 at 12:43 AM, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> On Oct 21, 2017, at 00:23, Ryan Libby <rlibby@FreeBSD.org> wrote: >> >> Author: rlibby >> Date: Sat Oct 21 07:23:45 2017 >> New Revision: 324811 >> URL: https://svnweb.freebsd.org/changeset/base/324811 >> >> Log: >> pms/freebsd: fix compiler warnings >> >> - A number of unused variable warnings, >> - a missing prototype warning (actually a dead function), >> - and a potential use of an uninitialized variable. > > You probably should look for the other _fantastic_ fixes that Danny Ryan = cooked up for the driver. I don=E2=80=99t think you=E2=80=99ve found the br= anches that result in logic errors which trigger corruption yet=E2=80=A6 > Cheers, > -Ngie Thanks, I will ping him. Yes, this is just from clang and gcc warnings and of that just for what's under sys/dev/pms/freebsd. I also have patches for fixes for warnings across sys/dev/pms, and pfg has a spelling fixup patch. There seems to be a little uncertainty about how to proceed wrt maintenance of the driver, so I won't be pushing those changes until that is clarified. (Is freebsd the de facto upstream now?)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFwhGsW31jr_qQgx7XZWHiCjkXeynWraH6hSNc3CrzTLMw>