Date: Mon, 15 Nov 2010 04:19:04 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: hastd/primary.c micro fixes Message-ID: <20101115031904.GJ4780@garage.freebsd.pl> In-Reply-To: <86wrogqn8d.fsf@kopusha.home.net> References: <86wrogqn8d.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--/0P/MvzTfyTu5j9Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 14, 2010 at 11:16:18AM +0200, Mikolaj Golub wrote: > Hi, >=20 > noticed the following in hastd/primary.c: >=20 > 1) in init_remote() when incoming connection is set up, if proto_client() > fails it only reports about the error and try proto_connect() anyway. This > will cause a crash as proto_conn structure is not valid. Primary should r= ather > exit (as it is when outgoing connection is set up, and as it is in the pa= tch > below) or set proto_conn pointer to NULL and goto close. >=20 > 2) in guard_thread() timeout.tv_sec is set in loop, while it looks like i= t may > be set only once before the loop. Thanks, I committed both changes. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --/0P/MvzTfyTu5j9Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkzgpqcACgkQForvXbEpPzQ4xwCfUdeVz3dOii6sW71zcXxXqhCV ZtYAn1xp+0jAHy2I5hKgh+lAba8DUGX/ =zP4z -----END PGP SIGNATURE----- --/0P/MvzTfyTu5j9Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101115031904.GJ4780>