Date: Thu, 1 Oct 2020 18:44:45 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Kyle Evans <kevans@freebsd.org> Cc: Alan Somers <asomers@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r366207 - head/lib/libc/gen Message-ID: <20201001154445.GA2643@kib.kiev.ua> In-Reply-To: <20200928160138.GP2643@kib.kiev.ua> References: <202009272226.08RMQf1h054050@repo.freebsd.org> <20200927231519.GI2643@kib.kiev.ua> <CAOtMX2iUKpFrJC1vUJ5_AF75L_GDr_4Rui2TdrA-qPLRc8aDNw@mail.gmail.com> <20200928150405.GO2643@kib.kiev.ua> <CACNAnaHWmZuusQeYMFiDG1wBxtJK6c8qa0Nv8im2M9SExP2gRA@mail.gmail.com> <20200928160138.GP2643@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 28, 2020 at 07:01:38PM +0300, Konstantin Belousov wrote: > On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote: > > I would be tempted to just revert the rest of the local modifications > > (sans negative check, maybe) and widen it in the one spot that the > > compiler complains about: > > > > - if (strlcpy(buf, execpath, buflen_) >= buflen_) > > + if (strlcpy(buf, execpath, buflen) >= (size_t)buflen) > > > > I had expressed this in the review, but with no particular conviction. > If this is the only place where the warning occurs, IMO it would be quite > good to reduce the change. So would you propose your change for review ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201001154445.GA2643>