Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Jan 2025 11:24:20 -0500
From:      John Baldwin <jhb@FreeBSD.org>
To:        Kyle Evans <kevans@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 04160e000898 - main - arm64: add a driver for the Apple Interrupt Controller
Message-ID:  <1a7f916d-ce0d-4ad2-ad8a-6ee75b747341@FreeBSD.org>
In-Reply-To: <202412171425.4BHEPuSP010250@gitrepo.freebsd.org>
References:  <202412171425.4BHEPuSP010250@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/17/24 09:25, Kyle Evans wrote:
> The branch main has been updated by kevans:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=04160e0008982fa0e03ebcc3747d81bcd547f751
> 
> commit 04160e0008982fa0e03ebcc3747d81bcd547f751
> Author:     Kyle Evans <kevans@FreeBSD.org>
> AuthorDate: 2024-12-17 14:14:54 +0000
> Commit:     Kyle Evans <kevans@FreeBSD.org>
> CommitDate: 2024-12-17 14:24:14 +0000
> 
>      arm64: add a driver for the Apple Interrupt Controller
>      
>      Some limited support for later multi-die SoC is included, but not at all
>      tested and not expected to be functional yet.  kevans needs to finish
>      getting his serial boards constructed, as the beefiest AS machine that
>      actually has multiple die to support in his fleet is currently a
>      dedicated serial console.
>      
>      Reviewed by:    andrew
>      Co-authored-by: Andrew Turner <andrew@FreeBSD.org>
>      Co-authored-by: Mike Karels <karels@FreeBSD.org>
>      Differential Revision:  https://reviews.freebsd.org/D48079

This doesn't build without `options SMP` so breaks make universe due to the
sys/arm64/conf/GENERIC-UP kernel config.

The first error is a simple fix in attach (local variable 'cpu' is unused),
but I wasn't quite sure what the right thing to do in the bus_setup_intr
method was for the AIC_TYPE_IRQ case where sc_cpuids is used unconditionally.

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1a7f916d-ce0d-4ad2-ad8a-6ee75b747341>