Date: Wed, 9 Dec 2020 21:46:57 +0100 From: Hans Petter Selasky <hps@selasky.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368492 - head/sbin/ifconfig Message-ID: <1d264658-6513-e2a2-062b-1b21296b054f@selasky.org> In-Reply-To: <fd2a5407-6039-a0f7-8d45-077c1dd292e1@selasky.org> References: <202012092013.0B9KDCAg083174@repo.freebsd.org> <fd2a5407-6039-a0f7-8d45-077c1dd292e1@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/9/20 9:19 PM, Hans Petter Selasky wrote:
> On 12/9/20 9:13 PM, Hans Petter Selasky wrote:
>> because the date pointed
>
> because the data pointed
> ^^ spelling fix
Just a heads up: I plan on making this a separate direct-commit to
12-stable tomorrow, because this change depends on, r366917, stacked
VLANs, which I have no intention of MFC'ing.
The fix for 12-stable looks like this:
> Index: sbin/ifconfig/ifclone.c
> ===================================================================
> --- sbin/ifconfig/ifclone.c (revision 368297)
> +++ sbin/ifconfig/ifclone.c (working copy)
> @@ -124,6 +124,7 @@
> struct ifreq ifr;
> struct clone_defcb *dcp;
> clone_callback_func *clone_cb = NULL;
> + const char *ifr_name = strchr(name, '.') ? "vlan" : name;
>
> memset(&ifr, 0, sizeof(ifr));
> (void) strlcpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
> @@ -131,7 +132,7 @@
> if (clone_cb == NULL) {
> /* Try to find a default callback */
> SLIST_FOREACH(dcp, &clone_defcbh, next) {
> - if (strncmp(dcp->ifprefix, ifr.ifr_name,
> + if (strncmp(dcp->ifprefix, ifr_name,
> strlen(dcp->ifprefix)) == 0) {
> clone_cb = dcp->clone_cb;
> break;
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1d264658-6513-e2a2-062b-1b21296b054f>