Date: Mon, 26 Oct 1998 00:38:49 -0800 (PST) From: asami@FreeBSD.ORG (Satoshi Asami) To: jkoshy@FreeBSD.ORG Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/misc/tet Makefile Message-ID: <199810260838.AAA05993@silvia.hip.berkeley.edu> In-Reply-To: <199810260310.TAA09873@freefall.freebsd.org> (message from Joseph Koshy on Sun, 25 Oct 1998 19:10:59 -0800 (PST))
next in thread | previous in thread | raw e-mail | index | archive | help
* Do something sensible for make clean if TET_ROOT is not defined. Add
* trailing slash to MASTER_SITE.
I don't understand this Makefile at all.
===
:
NO_PACKAGE= TET_ROOT needs to be set at compile time
:
pre-extract:
.if !defined(TET_ROOT)
@echo
@echo "The environment variable \"TET_ROOT\" is not set."
@echo "You must set it to the directory where you would like "
@echo "this port to reside before attempting extraction."
@echo
@false
.else
@true
.endif
# remove the TET_ROOT directory if it exists
pre-clean:
.if defined(TET_ROOT)
if [ -d ${TET_ROOT} ]; then ${RM} -rf ${TET_ROOT}; fi
.else
@true
.endif
:
post-clean:
${RM} -rf ${TET_ROOT}
.include <bsd.port.mk>
===
The ".else/@true" in pre-clean makes no sense. You meant
.if defined(TET_ROOT)
pre-clean:
${RM} -rf ${TET_ROOT}
.endif
? (No need for the -d test either, rm -rf won't error out on
non-existent directories.)
What is "post-clean"?
Also, you should just make TET_ROOT a compilation option unless
there's a very good reason not to do so. The spirit of ports
collection is to have a "canned" configuration that is easy to use,
and I see nothing wrong with having it default to ${PREFIX}/tet or
something.
Satoshi
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810260838.AAA05993>