Date: Wed, 23 Jul 2008 03:21:32 -0700 From: Xin LI <delphij@delphij.net> To: pav@FreeBSD.org Cc: cvs-ports@FreeBSD.org, d@delphij.net, Roman Bogorodskiy <novel@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/libvmime Makefile Message-ID: <4887062C.2010301@delphij.net> In-Reply-To: <1216800133.71570.4.camel@pav.hide.vol.cz> References: <200807230057.m6N0vjdA087753@repoman.freebsd.org> <4886952F.3080705@delphij.net> <1216800133.71570.4.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------060504000304030103050109
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 8bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Pav Lucistnik wrote:
| Xin LI píše v út 22. 07. 2008 v 19:19 -0700:
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA1
|>
|> Pav Lucistnik wrote:
|> | pav 2008-07-23 00:57:45 UTC
|> |
|> | FreeBSD ports repository
|> |
|> | Modified files:
|> | mail/libvmime Makefile
|> | Log:
|> | - Mark BROKEN: does not compile with gnutls-2.4.x
|>
|> Er, why, how can we say this version of gnutls is not broken when they
|> have this?
|>
|> ~ typedef enum gnutls_certificate_print_formats
|> ~ {
|> ~ GNUTLS_CRT_PRINT_FULL,
|> ~ GNUTLS_CRT_PRINT_ONELINE,
|> ~ GNUTLS_CRT_PRINT_UNSIGNED_FULL, // extra ","
|> ~ } gnutls_certificate_print_formats_t;
|
| I don't mind if it's fixed in libvmime or in gnutls port, as long as it
| get fixed.
Unfortunately this can *NOT* be fixed in libvmime because gnutls's
include file is broken. By making an instance of
gnutls_certificate_print_formats_t the compiler would notice the problem
immediately.
| BTW it's still this way in gnutls git.
I have submitted ticket #770 on gnutls trac. Just because it is still
in gnutls git does not mean that it is correct. Can we fix the (broken)
security/gnutls, rather than mark (the non-broken) libvmime broken? The
port works just fine with patched gnutls.
Cheers,
- --
Xin LI <delphij@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEARECAAYFAkiHBisACgkQi+vbBBjt66BeTgCeMuPm7Nl9h7zP7wqiAiup0n9O
LL4AoMBR/B+nCtjd4meHnE8OklIuKAip
=A34Q
-----END PGP SIGNATURE-----
--------------060504000304030103050109
Content-Type: text/plain;
name="patch-gnutls.h.in"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="patch-gnutls.h.in"
diff --git a/includes/gnutls/gnutls.h.in b/includes/gnutls/gnutls.h.in
index 13d507b..2025cdb 100644
--- a/includes/gnutls/gnutls.h.in
+++ b/includes/gnutls/gnutls.h.in
@@ -299,7 +299,7 @@ extern "C"
{
GNUTLS_CRT_PRINT_FULL,
GNUTLS_CRT_PRINT_ONELINE,
- GNUTLS_CRT_PRINT_UNSIGNED_FULL,
+ GNUTLS_CRT_PRINT_UNSIGNED_FULL
} gnutls_certificate_print_formats_t;
typedef enum
--------------060504000304030103050109--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4887062C.2010301>