Date: Wed, 20 Jun 2007 01:47:09 -0700 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-src@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c Message-ID: <4678E98D.3080905@FreeBSD.org> In-Reply-To: <20070620020138.GA2486@rot13.obsecurity.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <467863E0.2040906@FreeBSD.org> <20070619232125.GA750@rot13.obsecurity.org> <4678653B.8070409@FreeBSD.org> <20070619232451.GA872@rot13.obsecurity.org> <4678663E.2060204@FreeBSD.org> <20070620020138.GA2486@rot13.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote: > So the answer to my question is ... ? I'm still not sure you > understood it. If you are making no functional changes then the md5 > of the resulting binary will be unchanged, and this is in fact a good > way to check whether you are introducing functional changes or just > style/whitespace changes. Well, perhaps I did not make myself entirely clear. There were in fact some small functional changes (such as replacing fprintf(stderr...) with warnx() for consistency with the rest if the code and using abort(3) instead of exit(3) if sh.t happens) so that the checksum will not be the same. If you take a look at the patch it should be quite obvious what I am talking about. -Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4678E98D.3080905>