Date: Mon, 09 Jun 2008 09:15:21 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Tim Kientzle <kientzle@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Jeremie Le Hen <jeremie@le-hen.org>, cvs-all@freebsd.org Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile Message-ID: <484D5719.1070907@FreeBSD.org> In-Reply-To: <484CB927.3050101@freebsd.org> References: <200805261721.m4QHLCF4070787@repoman.freebsd.org> <20080608075256.GA35560@obiwan.tataz.chchile.org> <484CB927.3050101@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Tim Kientzle wrote:
> This case is a little unusual: by default, I want to
> install both 'cpio' programs and symlink the common name
> to one of them.
I'm not sure how that relates to Jeremie's (valid) point that these
flags need to be part of the system in bsd.own.mk. I admit that
getting stuff in there was a little intimidating to me at first, but
Ruslan has created a nice automated system, and he'll be glad to help
you if you need it.
> How about this:
> WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless
> WITH_BSDCPIO defined
> WITHOUT_GCPIO - does not install gcpio at all
> WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio'
> WITHOUT_BSDCPIO - does not install bsdcpio at all
If by "not install" you mean "build or install" then I'm with you, but
I think it might be a little complicated. I'm not sure why you want to
build and install both by default (except maybe to ease people's
concerns in the interim period) but if it were me, in HEAD I would do
this:
WITH_BSDCPIO (default) build, install, and symlink to cpio
WITHOUT_GCPIO (default) do not build or install
Then if WITHOUT_BSDCPIO is defined you don't build or install it, and
if WITH_GCPIO is defined you build, install, and symlink it,
regardless of the state of the BSDCPIO knob.
When this gets MFC'ed I would just flip the defaults.
FWIW,
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484D5719.1070907>