Date: Wed, 23 Sep 2015 20:08:25 -0700 From: Rui Paulo <rpaulo@me.com> To: Scott Long <scott4long@yahoo.com> Cc: Adrian Chadd <adrian.chadd@gmail.com>, jhb@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287934 - head/sys/boot/efi/loader Message-ID: <1443064105.14472.0.camel@me.com> In-Reply-To: <1F2C327F-433E-4FA6-A083-4565A32C1146@yahoo.com> References: <35a0f1b6-0236-4b0e-b919-00cab07429be@me.com> <1F2C327F-433E-4FA6-A083-4565A32C1146@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I gave you feedback: it crashed somewhere else. I haven't had time to work on it. However, go ahead and commit that fix. That code was clearly wrong. On Mon, 2015-09-21 at 23:21 -0700, Scott Long wrote: > As a side note, I’m still waiting for feedback on the patch I sent > you for scsi_sg. I’d like to get this fixed. > > Scott > > > On Sep 21, 2015, at 3:53 PM, Rui Paulo <rpaulo@me.com> wrote: > > > > No, that doesn't work very well. Not only the modules don't auto > > -load, the way the modules are compiled is different. See, for > > example, cam ctl which doesn't compile the sg code when it's built > > into the kernel, but compiles it when it's built as a module. The > > sg code is currently buggy and causes insta-panics with GNOME 3 > > (perhaps the auto-mounter in hald (?)). > > -- > > Rui Paulo > > > > > > On Sep 21, 2015, at 11:24 AM, Adrian Chadd <adrian.chadd@gmail.com> > > wrote: > > > > > Hi, > > > > > > Warner has been working on the modular kernel thing. But > > > honestly, I > > > think we should just start biting that bullet and ship a modules > > > -only > > > GENERIC by default.. > > > > > > > > > -a > > > > > > > > > On 21 September 2015 at 11:02, Rui Paulo <rpaulo@me.com> wrote: > > > > So, we're going to keep ignoring the problem and keep patching > > > > things up? > > > > It's a bit sad that a single driver (pmspcv) is able to cause > > > > so much > > > > problems. > > > > > > > > -- > > > > Rui Paulo > > > > > > > > > > > > On Sep 17, 2015, at 01:36 PM, John Baldwin <jhb@FreeBSD.org> > > > > wrote: > > > > > > > > Author: jhb > > > > Date: Thu Sep 17 20:36:46 2015 > > > > New Revision: 287934 > > > > URL: https://svnweb.freebsd.org/changeset/base/287934 > > > > > > > > > > > > Log: > > > > The EFI boot loader allocates a single chunk of contiguous > > > > memory to > > > > hold the kernel, modules, and any other loaded data. This > > > > memory block > > > > is relocated to the kernel's expected location during the > > > > transfer of > > > > control from the loader to the kernel. > > > > > > > > The GENERIC kernel on amd64 has recently grown such that a > > > > kernel + zfs.ko > > > > no longer fits in the default staging size. Bump the default > > > > size from > > > > 32MB to 48MB to provide more breathing room. > > > > > > > > PR: 201679 > > > > Reviewed by: imp > > > > MFC after: 1 week > > > > Differential Revision: https://reviews.freebsd.org/D3666 > > > > > > > > > > > > Modified: > > > > head/sys/boot/efi/loader/copy.c > > > > > > > > Modified: head/sys/boot/efi/loader/copy.c > > > > =============================================================== > > > > =============== > > > > --- head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:34 2015 > > > > (r287933) > > > > +++ head/sys/boot/efi/loader/copy.c Thu Sep 17 20:36:46 2015 > > > > (r287934) > > > > @@ -38,7 +38,7 @@ __FBSDID("$FreeBSD$"); > > > > #include <efilib.h> > > > > > > > > #ifndef EFI_STAGING_SIZE > > > > -#define EFI_STAGING_SIZE 32 > > > > +#define EFI_STAGING_SIZE 48 > > > > #endif > > > > > > > > #define STAGE_PAGES ((EFI_STAGING_SIZE) * 1024 * 1024 / 4096) > > > > > -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1443064105.14472.0.camel>