Date: Thu, 4 Sep 2025 10:14:02 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Jake Freeland <jfree@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9404c479946c - main - pci_user: Report NUMA domain Message-ID: <d0051f9e-6828-4e2e-aba4-debf2608d9e3@FreeBSD.org> In-Reply-To: <202509040245.5842jXvV085511@gitrepo.freebsd.org> References: <202509040245.5842jXvV085511@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/3/25 22:45, Jake Freeland wrote: > The branch main has been updated by jfree: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9404c479946c00b6ac94253d2037c47251dc606c > > commit 9404c479946c00b6ac94253d2037c47251dc606c > Author: Jake Freeland <jfree@FreeBSD.org> > AuthorDate: 2025-09-04 02:42:23 +0000 > Commit: Jake Freeland <jfree@FreeBSD.org> > CommitDate: 2025-09-04 02:42:23 +0000 > > pci_user: Report NUMA domain > > A PCI device's NUMA domain is now accessible via the pd_numa_domain > member of struct pci_conf when using the PCIOCGETCONF ioctl. > > A new ioctl number has been assigned to PCIOCGETCONF to preserve > compatibility with binaries compiled on FreeBSD versions 7 through 14. > Such binaries can continue to use the PCIOCGETCONF ioctl number > that they were compiled with and experience no ABI repercussions. > > Reviewed by: imp, markj > Differential Revision: https://reviews.freebsd.org/D44289 For future reference: you didn't need to bump to a new number for the ioctl since the size of the argument is encoded in the ioctl as well. This feature of ioctls also means that we generally don't add padding (as you did in the followup commit) as you will naturally get a new ioctl cmd value anytime you add more fields in the future. This avoids the one point Warner raised in the review about how do you define the semantics of the padding as that approach defers reserving space in the structure until the semantics of that space is known. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0051f9e-6828-4e2e-aba4-debf2608d9e3>