Date: Fri, 30 Jun 2023 14:14:17 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Mitchell Horne <mhorne@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors Message-ID: <79845.1688159657@kaos.jnpr.net> In-Reply-To: <B59305E1-680B-4793-9779-B872E76B6A34@freebsd.org> References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> <498f3ba2-dc7a-e7d3-626a-76ca68cee5b2@freebsd.org> <B59305E1-680B-4793-9779-B872E76B6A34@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jessica Clarke <jrtc27@freebsd.org> wrote: > A conditional assignment of the same value that has already been > assigned unconditionally is unidiomatic code generally regarded as a > code smell and should be avoided. In an ideal world that would give a I agree. I've been bitten by __unused recently when porting stuff to linux so was looking to avoid that.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?79845.1688159657>