Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 May 2013 09:14:21 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        Martin Wilke <miwi.freebsd@gmail.com>, Chris Rees <crees@freebsd.org>, Ports Management Team <portmgr@freebsd.org>, FreeBSD Ports <ports@freebsd.org>, Eitan Adler <lists@eitanadler.com>, Olivier Smedts <olivier@gid0.org>, Martin Wilke <miwi@bsdhash.org>, Bryan Drewery <bryan@shatow.net>
Subject:   Re: Plans for making MAKE_JOBS_SAFE the default?
Message-ID:  <519E243D.9020501@FreeBSD.org>
In-Reply-To: <20130523130041.GA47068@FreeBSD.org>
References:  <CAF6rxgkjxAmFjr=qp%2BDC83AqvY4CMXVn5=CQCfQi_aKn3bnoRQ@mail.gmail.com> <50463F7F.2030502@shatow.net> <CABzXLYNQBVZAkL%2B-HMUVduzq_UKLEjbQFE4zn_KhCBE3agX-Hw@mail.gmail.com> <CAF6rxgmx0bJcW-iP_a8B3y9x9T%2BxF0MNsW55ciJJOnKPfQEMSA@mail.gmail.com> <CADLo83-126TsyWatUREysrk2gR7%2BacxWqTxmW0WhwH=QYW=hfg@mail.gmail.com> <CAF6rxgk-kL6UXRES6KWqQtOSd6rvKV4E-hgHLcAXSCEA9vVy-g@mail.gmail.com> <1A22DCEC-9548-4FD2-BFC5-4F3F4EC1E1C2@gmail.com> <A8B05539-6878-48DE-8DC0-3323263594AF@bsdhash.org> <20130523075627.GA79696@FreeBSD.org> <519E0912.4070500@FreeBSD.org> <20130523130041.GA47068@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2SNWXUGQIVQDTTNXOBNAW
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 5/23/2013 8:00 AM, Alexey Dokuchaev wrote:
> On Thu, May 23, 2013 at 07:18:26AM -0500, Bryan Drewery wrote:
>> On 5/23/2013 2:56 AM, Alexey Dokuchaev wrote:
>>> FORCE_MAKE_JOBS is removed because it is the default.  While here, I'=
ve
>>> moved empty(MAKE_JOBS_NUMBER) check higher, IMHO where it should belo=
ng,
>>> also saves a few lines.  Reviews are welcome.
>>
>> Moving MAKE_JOBS_NUMBER is wrong, see r317639
>=20
> Hmm, can you explain a bit more?  Maybe I am missing something here, bu=
t
> as I read log for r317639:
>=20
>   "[F]ix MAKE_JOBS_NUMBER not being set if none of DISABLE_MAKE_JOBS or=

>    MAKE_JOBS_UNSAFE or MAKE_JOBS_SAFE or FORCE_MAKE_JOBS were set."
>=20
> Previously (without my patch) it could happen because of nested .if's. =
 Now
> _MAKE_JOBS is set in both branches (true and false).  Simple test on a =
port
> that does not set any MAKE_JOBS_* stuff, e.g. games/qcc:
>=20
>   $ make -V MAKE_JOBS_NUMBER
>   `/sbin/sysctl -n kern.smp.cpus`
>   $ make -V MAKE_JOBS_NUMBER -DDISABLE_MAKE_JOBS
>   1
>   $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_UNSAFE
>   1
>   $ make -V MAKE_JOBS_NUMBER -DMAKE_JOBS_SAFE
>   `/sbin/sysctl -n kern.smp.cpus`
>   $ make -V MAKE_JOBS_NUMBER -DFORCE_MAKE_JOBS
>   `/sbin/sysctl -n kern.smp.cpus`
>=20
> Can you show how can I get undefined _MAKE_JOBS?
>=20
> ./danfe
>=20

I see now. You removed this

-.if defined(MAKE_JOBS_SAFE) || defined(FORCE_MAKE_JOBS)

So it should be fine now.

--=20
Regards,
Bryan Drewery


------enig2SNWXUGQIVQDTTNXOBNAW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRniQ9AAoJEG54KsA8mwz5OlIQAIBI5NUR/z66vp66uqRX9Z3/
Ne2rCAae59VLSRQdkeRJ6A5cg+CMr5P6xegDG9klShBLCyeQQ2nHpcUKg8nPl8b5
fH/PMN3ddnTi/fW/hzf2fBBb2kDM/xk9XCFV1eeFUcXdBDq43qd9zIIYvjux+Bpb
KNYg+lFya2D+0nRDsvTgb5gPeJyn5aFcP2+NecAmxxwUeksLLWYG/AijtUZgJ2Xa
CXa7DxC3s97JtGuW22U+3HocHT73F9/O5HkwCarTluOlNgW4aBfv68sETHCC5IGS
TGD1aN+zh7ScMTyPjF+WSSg7s3lUA6G5jTrzbafAmU6yXoGDsRkOLYE/pGxuUcBH
fRaeQXycQn5YVdFKlskwGk907CBaI6gSs0fpdO3Z7e1tHCsW1zNwVUr7fWKuyrtZ
1tdAoFZdUH/p0HEMPFGpN/sZr6+CE550h2jdZY9DsukwEPoADOdTSO76dXwRKAUE
jioVIPpMsttOltD7GSFdSR6RFO7CYTzDJKCSnDDro+ExkS/Au2c3Ma73zNr1SVXX
GEzstlrfr55ZJ+1nmPFpAfNtIufZubNryNo3IBZ9+vhRhqDnVflmAcTieTiMOk+L
VG1n7uaL/DXN0JUj69NfQ2X+vKG1vchpstNpxlWBsTuPWvTN4aLcNbGNWEinuXOn
kmyTu7ZF+pThjFQkCtjh
=ZGHv
-----END PGP SIGNATURE-----

------enig2SNWXUGQIVQDTTNXOBNAW--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?519E243D.9020501>