Date: Fri, 9 Mar 2012 17:11:41 +0100 From: Tijl Coosemans <tijl@freebsd.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232721 - head/sys/x86/include Message-ID: <201203091711.45604.tijl@freebsd.org> In-Reply-To: <20120309154707.GB27469@hoeg.nl> References: <201203091148.q29BmuIp005151@svn.freebsd.org> <20120309154707.GB27469@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1552931.9rx4fqYbL6 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Friday 09 March 2012 16:47:07 Ed Schouten wrote: > * Tijl Coosemans <tijl@FreeBSD.org>, 20120309 12:48: >> Clean up x86 endian.h: >=20 > Wouldn't it be possible to simply place these macros in <sys/endian.h> > and only let <machine/endian.h> define the assembly versions for the > non-constant cases? Several things could be moved to sys, not just endian.h, but I'd like to finish merging amd64/i386 headers first. Also, for clang and gcc >=3D 4.3 it's better to use __builtin_bswapNN(x), because it can use movbe rather than mov+bswap when x is a memory operand. --nextPart1552931.9rx4fqYbL6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk9aK8EACgkQfoCS2CCgtisQSgD/bSh41FegN7GHd4WS5+iDrzdD l3yIqGbg7l7kX9j4E18A/jZsccCrNAkYFJeqzyVz7H82/8e2tVZ+u+ePDEi2BqOc =GTf0 -----END PGP SIGNATURE----- --nextPart1552931.9rx4fqYbL6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203091711.45604.tijl>