Date: Wed, 6 May 2020 11:40:32 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r360689 - stable/11/sys/fs/smbfs Message-ID: <202005061140.046BeWvi035493@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Wed May 6 11:40:32 2020 New Revision: 360689 URL: https://svnweb.freebsd.org/changeset/base/360689 Log: MFC r316584 (by cem): smbfs: Fix an indentation level Based on the change in r242386, it seems clear that scred was intended to be released in all paths at exit. No functional change. This line's indent was just the result of a bad copy paste from the previous free() in an early exit path. Reported by: PVS-Studio Sponsored by: Dell EMC Isilon Modified: stable/11/sys/fs/smbfs/smbfs_vnops.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/fs/smbfs/smbfs_vnops.c ============================================================================== --- stable/11/sys/fs/smbfs/smbfs_vnops.c Wed May 6 11:10:13 2020 (r360688) +++ stable/11/sys/fs/smbfs/smbfs_vnops.c Wed May 6 11:40:32 2020 (r360689) @@ -280,7 +280,7 @@ smbfs_getattr(ap) smbfs_attr_cachelookup(vp, va); if (np->n_flag & NOPEN) np->n_size = oldsize; - smbfs_free_scred(scred); + smbfs_free_scred(scred); return 0; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005061140.046BeWvi035493>