Date: Mon, 10 Jan 2022 21:07:22 GMT From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: cdd7fe04cb80 - main - cxgbe(4): Do not ignore the return value of ifmedia_ioctl. Message-ID: <202201102107.20AL7MaH005480@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b commit cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b Author: Navdeep Parhar <np@FreeBSD.org> AuthorDate: 2022-01-10 21:01:51 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2022-01-10 21:05:01 +0000 cxgbe(4): Do not ignore the return value of ifmedia_ioctl. This ensures that the driver reports an error instead of failing silently when an invalid media is requested. Reported by: Suhas Lokesha @ Chelsio MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 183344099bfe..58b064e78402 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -2869,7 +2869,7 @@ fail: case SIOCSIFMEDIA: case SIOCGIFMEDIA: case SIOCGIFXMEDIA: - ifmedia_ioctl(ifp, ifr, &pi->media, cmd); + rc = ifmedia_ioctl(ifp, ifr, &pi->media, cmd); break; case SIOCGI2C: {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201102107.20AL7MaH005480>