Date: Mon, 10 Jan 2022 14:14:54 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: d6c0538dae8d - main - ddb: Remove SOFTWARE_SSTEP support Message-ID: <CANCZdfq0UCZvdcsuaWx3KXqrKBBYoxDHqc=_P3U7L4QpCyh=rw@mail.gmail.com> In-Reply-To: <45275428-75e2-aaae-bed3-e5e84b39e17c@FreeBSD.org> References: <202201071627.207GRsGX062055@gitrepo.freebsd.org> <45275428-75e2-aaae-bed3-e5e84b39e17c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jan 10, 2022 at 12:48 PM John Baldwin <jhb@freebsd.org> wrote: > On 1/7/22 8:27 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=d6c0538dae8d138219dfd051994a44c50e741212 > > > > commit d6c0538dae8d138219dfd051994a44c50e741212 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2022-01-07 16:25:33 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2022-01-07 16:25:33 +0000 > > > > ddb: Remove SOFTWARE_SSTEP support > > > > It was needed for mips only, and only kinda sorta worked for mips. > It > > can be brought back if we grow another architecture that need it. > > > > Sponsored by: Netflix > > RISC-V would need it in theory (no hardware single step), but no one has > felt the > need to implement the backend support for it. I think 32-bit arm doesn't > support > hardware single step either (but again, no one has bothered to add the > backend > support). > Generally, I agree with these thoughts. I went ahead with the removal because I knew it would be easy to bring back, even years from now should someone[tm] have an implementation for those platforms (though I thought 32-bit arm did have single step in hardware). Should I put it back? Or should we wait until someone shows up with support for a supported platform? Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 10, 2022 at 12:48 PM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/7/22 8:27 AM, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=d6c0538dae8d138219dfd051994a44c50e741212" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=d6c0538dae8d138219dfd051994a44c50e741212</a><br>; > <br> > commit d6c0538dae8d138219dfd051994a44c50e741212<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2022-01-07 16:25:33 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2022-01-07 16:25:33 +0000<br> > <br> > ddb: Remove SOFTWARE_SSTEP support<br> > <br> > It was needed for mips only, and only kinda sorta worked for mips. It<br> > can be brought back if we grow another architecture that need it.<br> > <br> > Sponsored by: Netflix<br> <br> RISC-V would need it in theory (no hardware single step), but no one has felt the<br> need to implement the backend support for it. I think 32-bit arm doesn't support<br> hardware single step either (but again, no one has bothered to add the backend<br> support).<br></blockquote><div><br></div><div>Generally, I agree with these thoughts. I went ahead with the removal because I</div><div>knew it would be easy to bring back, even years from now should someone[tm]</div><div>have an implementation for those platforms (though I thought 32-bit arm did have</div><div>single step in hardware).</div><div><br></div><div>Should I put it back? Or should we wait until someone shows up with support for</div><div>a supported platform?</div><div><br></div><div>Warner</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq0UCZvdcsuaWx3KXqrKBBYoxDHqc=_P3U7L4QpCyh=rw>