Date: Mon, 6 Dec 2021 20:51:02 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: ab4524b3d7fb - main - amd64: wrap 64bit sigtramp into vdso Message-ID: <BDD795B9-F98E-48FC-BD89-10D3C5AE89AE@freebsd.org> In-Reply-To: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> References: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 Dec 2021, at 18:48, Konstantin Belousov <kib@FreeBSD.org> wrote: >=20 > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dab4524b3d7fba872a143b03c9346cb04= c3670efa >=20 > commit ab4524b3d7fba872a143b03c9346cb04c3670efa > Author: Konstantin Belousov <kib@FreeBSD.org> > AuthorDate: 2021-11-05 08:07:24 +0000 > Commit: Konstantin Belousov <kib@FreeBSD.org> > CommitDate: 2021-12-06 18:46:49 +0000 >=20 > amd64: wrap 64bit sigtramp into vdso >=20 > Reviewed by: emaste > Discussed with: jrtc27 > Tested by: pho > Sponsored by: The FreeBSD Foundation > MFC after: 1 month > Differential revision: https://reviews.freebsd.org/D32960 This broke cross-building from non-FreeBSD: > ERROR: ctfconvert: elf-vdso.so.o doesn't have type data to convert The error message also shows up on FreeBSD, but ctfconvert has a gross #ifdef __FreeBSD__ hack in it to make it non-fatal (dating right back to when it was imported), which of course doesn=E2=80=99t work when = building on non-FreeBSD, and is something I=E2=80=99ve wanted to remove from FreeBSD = too as silently allowing broken CTF is a bad idea these days (see AArch64 where LLVM 13 bogusly emits DWARF using C++ constructs for C, breaking CTF entirely, which wasn=E2=80=99t caught until it was built on = non-FreeBSD). I imagine this just needs no-ctfconvert in files.amd64 for both VDSOs? Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BDD795B9-F98E-48FC-BD89-10D3C5AE89AE>