Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 May 2025 03:57:05 GMT
From:      Doug Moore <dougm@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5239a9fb8662 - main - vm_page: alloc_domain_iter
Message-ID:  <202505170357.54H3v5qP078683@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by dougm:

URL: https://cgit.FreeBSD.org/src/commit/?id=5239a9fb8662c1f87dd5a963c044d80b16206a72

commit 5239a9fb8662c1f87dd5a963c044d80b16206a72
Author:     Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2025-05-17 03:54:33 +0000
Commit:     Doug Moore <dougm@FreeBSD.org>
CommitDate: 2025-05-17 03:54:33 +0000

    vm_page: alloc_domain_iter
    
    A recent change that made a call to pctrie_iter_reset conditional was
    ill-advised, as it leads to an assertion failure on the graid1_6.sh
    stress2 test.  Make it unconditional again.
    
    Reported by:    pho
    Fixes:  3fe2f81f665b ("vm_page: reduce iter_reset calls in alloc_domain_iter")
---
 sys/vm/vm_page.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c
index ecf8f5c73a5e..91250060190d 100644
--- a/sys/vm/vm_page.c
+++ b/sys/vm/vm_page.c
@@ -2142,8 +2142,7 @@ again:
 		 * Not allocatable, give up.
 		 */
 		(void)vm_domain_alloc_fail(vmd, object, req);
-		if ((req & VM_ALLOC_WAITFAIL) != 0)
-			pctrie_iter_reset(pages);
+		pctrie_iter_reset(pages);
 		return (NULL);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505170357.54H3v5qP078683>