Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 19:50:24 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 8d5e624d8daf - stable/14 - TCP RACK: don't use an uninitialized variable
Message-ID:  <202502051950.515JoOPA079299@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=8d5e624d8daf05b778ac3f10d085a670eef5a2c0

commit 8d5e624d8daf05b778ac3f10d085a670eef5a2c0
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-12-31 16:26:04 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 08:50:40 +0000

    TCP RACK: don't use an uninitialized variable
    
    When storing the old beta values in rack_swap_beta_values(),
    ensure that the newreno_flags field is initialized appropriately
    instead of using an uninitialized value.
    Since the stored newreno_flags aren't actually used, this fix
    should not have any functional change.
    
    Reviewed by:            rrs
    CID:                    1523796
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48260
    
    (cherry picked from commit 4f3a0c719780fdd57c660ceb353bbc71fc555600)
---
 sys/netinet/tcp_stacks/rack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index 061bc286e11c..3d13ff380a8e 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -631,6 +631,7 @@ rack_swap_beta_values(struct tcp_rack *rack, uint8_t flex8)
 		failed = 2;
 		goto out;
 	}
+	old.newreno_flags = CC_NEWRENO_BETA_ECN_ENABLED;
 	/* Get the current values out */
 	sopt.sopt_valsize = sizeof(struct cc_newreno_opts);
 	sopt.sopt_dir = SOPT_GET;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502051950.515JoOPA079299>