Date: Mon, 1 Nov 2004 09:31:10 -0500 (EST) From: Daniel Eischen <deischen@freebsd.org> To: Brian Feldman <green@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c Message-ID: <Pine.GSO.4.43.0411010927380.27281-100000@sea.ntplx.net> In-Reply-To: <Pine.GSO.4.43.0410310608001.21125-100000@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 31 Oct 2004, Daniel Eischen wrote: > On Sun, 31 Oct 2004, Brian Feldman wrote: > > > green 2004-10-31 05:03:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > lib/libpthread/thread thr_mutex.c > > Log: > > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > > packages expect and seems to be most correct according to the slightly- > > ambiguous standards. > > > > MFC after: 1 month > > Corroborated by: POSIX <http://tinyurl.com/4uvub>; > > Reviewed by: silence on threads@ > > I never saw this, and there has been a couple of long threads about > it. The current behavior was deemed correct especially since default > mutexes are error check mutexes. The rationale is that it provides a way > for a thread to tell if it owns the mutex if EDEADLK is returned. > > Please back out and sorry for not seeing a posting on -threads. I retract the backout request. I have response from Dave Butenhof over at the Austin Group mailing list, and EBUSY should be returned even for error check mutexes. He acknolwedged the spec was not clear and thought they had cleaned it up in that regard. So this is the correct fix :-) -- Dan Eischen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.43.0411010927380.27281-100000>