Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Nov 2016 14:42:16 -0500
From:      Ed Maste <emaste@freebsd.org>
To:        Luigi Rizzo <luigi@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r308000 - in head/sys: dev/netmap net
Message-ID:  <CAPyFy2BP29%2BFB4PYMOZCh=1FvD091uXZopvR1zzZSkeHc8wpOQ@mail.gmail.com>
In-Reply-To: <201610270946.u9R9kMc0010656@repo.freebsd.org>
References:  <201610270946.u9R9kMc0010656@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 27 October 2016 at 05:46, Luigi Rizzo <luigi@freebsd.org> wrote:
> Author: luigi
> Date: Thu Oct 27 09:46:22 2016
> New Revision: 308000
> URL: https://svnweb.freebsd.org/changeset/base/308000
>
> Log:
>   Various fixes for ptnet/ptnetmap (passthrough of netmap ports). In detail:
>   - use PCI_VENDOR and PCI_DEVICE ids from a publicly allocated range
>     (thanks to RedHat)
>   - export memory pool information through PCI registers
>   - improve mechanism for configuring passthrough on different hypervisors
>   Code is from Vincenzo Maffione as a follow up to his GSOC work.
...
> @@ -1099,7 +1090,7 @@ nm_kthread_worker(void *data)
>                                 continue;
>                         } else if (nmk->run) {
>                                 /* wait on event with one second timeout */
> -                               msleep_spin(ctx->ioevent_file, &nmk->worker_lock,
> +                               msleep_spin((void *)ctx->cfg.wchan, &nmk->worker_lock,
>                                             "nmk_ev", hz);
>                                 nmk->scheduled++;
>                         }

Hi Luigi,

This breaks "make tinderbox" in powerpc LINT with:

/scratch/tmp/emaste/freebsd/sys/dev/netmap/netmap_freebsd.c: In
function 'nm_os_kthread_wakeup_worker':
/scratch/tmp/emaste/freebsd/sys/dev/netmap/netmap_freebsd.c:1027:
warning: cast to pointer from integer of different size
[-Wint-to-pointer-cast]
/scratch/tmp/emaste/freebsd/sys/dev/netmap/netmap_freebsd.c: In
function 'nm_kthread_worker':
/scratch/tmp/emaste/freebsd/sys/dev/netmap/netmap_freebsd.c:1093:
warning: cast to pointer from integer of different size
[-Wint-to-pointer-cast]
*** [netmap_freebsd.o] Error code 1



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BP29%2BFB4PYMOZCh=1FvD091uXZopvR1zzZSkeHc8wpOQ>