Date: Tue, 4 Dec 2018 11:55:23 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Xin LI <delphij@gmail.com>, Renato Botelho do Couto <garga@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341464 - head/sbin/savecore Message-ID: <CANCZdfoPFDYQAreZn6K%2BTzAUkLm0zPcrKBvn6NCYdX%2B_yqSB=g@mail.gmail.com> In-Reply-To: <201812041813.wB4IDhd1037433@pdx.rh.CN85.dnsmgr.net> References: <CAGMYy3tWs902oZBZ6fBSjBCCkT1_17hKsZzAP__XFJNO%2Bg6Mrw@mail.gmail.com> <201812041813.wB4IDhd1037433@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 4, 2018 at 11:14 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Tue, Dec 4, 2018 at 9:28 AM Rodney W. Grimes > > > > > > > Author: garga (ports committer) > > > > Date: Tue Dec 4 12:34:22 2018 > > > > New Revision: 341464 > > > > URL: https://svnweb.freebsd.org/changeset/base/341464 > > > > > > > > Log: > > > > Restore /var/crash permissions to 0750, as declared in mtree file. > After > > > > r337337 it changed to 0755. > > > > > > > > Reviewed by: loos > > > > Approved by: loos > > > > MFC after: 3 days > > > > Sponsored by: Rubicon Communications, LLC (Netgate) > > > > Differential Revision: https://reviews.freebsd.org/D18355 > > > > > > This probably warrants an EN against 12.0 release. > > > > Can we just fix it before 12.0-RELEASE builds starts? It would be > > much more robust compared to delivering a "fixit" script though > > freebsd-update... > > Thats Glens call, but normal procedure is 0 change between > last RC and release. > Let's not be too pedantic here: This is a security issue and let's not let our process get in the way of fixing a simple security issue. Warner > (Bcc:'ed to gjb@, and trimmed a bit) > > Rod > > > > +++ head/sbin/savecore/Makefile Tue Dec 4 12:34:22 2018 > (r341464) > > > > @@ -2,7 +2,9 @@ > > > > > > > > PACKAGE=runtime > > > > CONFS= minfree > > > > -CONFSDIR= /var/crash > > > > +VAR_CRASH= /var/crash > > > > +VAR_CRASH_MODE= 0750 > > > > +CONFSDIR= VAR_CRASH > > > > PROG= savecore > > > > LIBADD= z xo > > > > MAN= savecore.8 > -- > Rod Grimes > rgrimes@freebsd.org > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoPFDYQAreZn6K%2BTzAUkLm0zPcrKBvn6NCYdX%2B_yqSB=g>