Date: Sun, 20 Aug 2023 02:57:11 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: Daniel Engberg <daniel.engberg.lists@pyret.net>, Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 Message-ID: <ZOGBB5E3B59PIY8d@FreeBSD.org> In-Reply-To: <ttsv-cxut-wny@FreeBSD.org> References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> <ttsv-cxut-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 19, 2023 at 09:09:14AM +0200, Jan Beich wrote: > Daniel Engberg <daniel.engberg.lists@pyret.net> writes: > > On 2023-08-16 21:44, Po-Chuan Hsieh wrote: > >> --- a/devel/utf8cpp/Makefile > >> +++ b/devel/utf8cpp/Makefile > >> @@ -1,9 +1,9 @@ > >> PORTNAME= utf8cpp > >> +PORTVERSION= 3.2.4 > >> DISTVERSIONPREFIX= v > >> -DISTVERSION= 3.2.3 > [...] > > Can you please revert you changes so the port don't deviate from > > Porters Handbook? > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > > - Example 16 > > Did you overquote the whole commit just for DISTVERSION vs. PORTVERSION? Overquoting is a big problem these days, unfortunately. Alas, few of us seem to care. :( Regarding this commit, for 3.2.4, both PORTVERSION and DISTVERSION could be used, with PORTVERSION bearing less cognitive load on the reader IMO. Knob order matter is minuscule in this particular case. The only "real" issue here is uglified pkg-descr: now the right edge is rugged and touches 80-char limit while we typically leave some padding, exact number of spaces depends on the best text alignment (and one's taste; we're lacking in that department as well). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZOGBB5E3B59PIY8d>