Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Jul 2013 23:24:00 +0400
From:      Andrey Chernov <ache@freebsd.org>
To:        obrien@freebsd.org
Cc:        svn-src-head@freebsd.org, =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng
Message-ID:  <51F812D0.90302@freebsd.org>
In-Reply-To: <20130730185034.GA63635@dragon.NUXI.org>
References:  <201307292058.r6TKwA56031193@svn.freebsd.org> <86fvuwgrs6.fsf@nine.des.no> <20130730185034.GA63635@dragon.NUXI.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 30.07.2013 22:50, David O'Brien wrote:
> Hi DES,
> Where was this policy published or communicated?
> There is no MAINTAINER line in sys/dev/random/, nor an entry in
> /usr/src/MAINTAINERS.  It is hard to follow some policy that cannot
> be found.

~5 years ago I was forced to stop commits due to this policy invented on
the fly and differently applied by different secteam@ members. Sad story.

> Do you have any specific concerns?

What about arc4rand_iniseed_state code dead without yarrow loaded?

randomdev_soft.c:
void
random_yarrow_unblock(void)
{
        if (!random_systat.seeded) {
                random_systat.seeded = 1;
                selwakeuppri(&random_systat.rsel, PUSER);
                wakeup(&random_systat);
        }
        (void)atomic_cmpset_int(&arc4rand_iniseed_state, ARC4_ENTR_NONE,
            ARC4_ENTR_HAVE);
}



-- 
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51F812D0.90302>