Date: Thu, 28 Oct 2004 21:08:22 -0400 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Julian Elischer <julian@elischer.org> Cc: John Baldwin <jhb@freebsd.org> Subject: Re: MFC req for 5.x/5.3 Message-ID: <20041029010822.GA12081@electra.cse.Buffalo.EDU> In-Reply-To: <41817EE4.9080302@elischer.org> References: <Pine.GSO.4.43.0410281908000.5783-100000@sea.ntplx.net> <41817EE4.9080302@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--x+6KMIRAuhnl3hBn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Oct 28, 2004 at 04:21:08PM -0700, Julian Elischer wrote:
> Daniel Eischen wrote:
> >On Thu, 28 Oct 2004, Julian Elischer wrote:
> >>David Xu wrote:
> >>>Here is the cvs log:
> >>>
> >>>Revision Changes Path
> >>> 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c
> >>> 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c
> >>> 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c
> >>> 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h
> >>> 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c
> >>>
> >>commit message was:
> >>1. Move thread list flags into new separate member, and atomically
> >> put DEAD thread on GC list, this closes a race between pthread_join
> >> and thr_cleanup.
> >>2. Introduce a mutex to protect tcb initialization, tls allocation and
> >> deallocation code in rtld seems no lock protection or it is broken,
> >> under stress testing, memory is corrupted.
> >>
> >>translates to:
> >>
>=20
> [diff removed]
>=20
> >
> >Yes, these look right.
> >
Ok. If you have done a complete buildworld/installworld test on
RELENG_5 with the patches you sent please MFC it to RELENG_5 and
RELENG_5_3. If you haven't done a complete buildworld/installworld
test with these patches please just MFC to RELENG_5 and let me know,
I'll test it there before we do the jump to RELENG_5_3. Sorry for
being this jumpy about it but this does look like a slightly
complicated MFC. It looks like there had been other changes to
libpthread/thread between the RELENG_5 branch and now that you are not
MFC-ing at this point. I need to do tags slips with what hits
RELENG_5_3 so I need to be a bit careful with what gets that far. And
I know not everyone has a ton of machines around they can test the
various stages on so if it's a bit hard for you to do the full
buildworld/installworld tests I can take care of that for you.
Thanks.
--=20
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
--x+6KMIRAuhnl3hBn
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (SunOS)
iD8DBQFBgZgE/G14VSmup/YRAt6dAJwPX+3XqCnWiU7o1i/JhhrenbMcjgCgi7ns
bSc7E/lCARFOE2l3d02GNxE=
=oGVe
-----END PGP SIGNATURE-----
--x+6KMIRAuhnl3hBn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041029010822.GA12081>