Date: Tue, 01 Mar 2016 11:32:24 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r409855 - in head: lang/tcl86 lang/tcl86/files x11-toolkits/tk86 Message-ID: <700ef31768041a75d192c1703530eead@gahr.ch> In-Reply-To: <6C71D4ECCA17E729D8CA7F38@atuin.in.mat.cc> References: <201603010931.u219VhfM013833@repo.freebsd.org> <6C71D4ECCA17E729D8CA7F38@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-03-01 10:58, Mathieu Arnold wrote: > +--On 1 mars 2016 09:31:43 +0000 Pietro Cerutti <gahr@FreeBSD.org> > wrote: > | +TEST_TARGET= do-test > > That should not be needed, the fact that you have a do-test target will > have "make test" work the right way. > > | +TCLMAN_VARS= INSTALL_TARGET+=install-doc > | +TZDATA_VARS= INSTALL_TARGET+=install-tzdata > | +MODULES_VARS= INSTALL_TARGET+=install-modules > > These three should be written as: > > TCLMAN_INSTALL_TARGET=install-doc > TZDATA_INSTALL_TARGET=install-tzdata > MODULES_INSTALL_TARGET=install-modules > > instead of using the _VARS construct. The porter's handbook do say, in > red: > > Before using OPT_VARS and OPT_VARS_OFF, see if there is already > a > more specific helper available > > With a link to the correct section. > > | +.include <bsd.port.options.mk> > > You can drop this if you use the post-patch-TCLMAN-off: target. All applied, thank you! -- Pietro Cerutti gahr@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?700ef31768041a75d192c1703530eead>