Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Nov 2013 10:58:03 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r258545 - head/sys/dev/usb/controller
Message-ID:  <201311251058.rAPAw3IC099963@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Mon Nov 25 10:58:02 2013
New Revision: 258545
URL: http://svnweb.freebsd.org/changeset/base/258545

Log:
  Comply to the XHCI specification. Certain input context fields should
  always be zero.
  
  MFC after:	1 week

Modified:
  head/sys/dev/usb/controller/xhci.c

Modified: head/sys/dev/usb/controller/xhci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci.c	Mon Nov 25 10:49:17 2013	(r258544)
+++ head/sys/dev/usb/controller/xhci.c	Mon Nov 25 10:58:02 2013	(r258545)
@@ -2540,7 +2540,11 @@ xhci_configure_device(struct usb_device 
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx2, temp);
 
-	temp = XHCI_SCTX_3_DEV_ADDR_SET(udev->address) |
+	/*
+	 * These fields should be initialized to zero, according to
+	 * XHCI section 6.2.2 - slot context:
+	 */
+	temp = XHCI_SCTX_3_DEV_ADDR_SET(0) |
 	    XHCI_SCTX_3_SLOT_STATE_SET(0);
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx3, temp);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311251058.rAPAw3IC099963>