Date: Sat, 26 Mar 2022 10:29:49 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added (+) Message-ID: <86fsn46dv6.fsf@phe.ftfl.ca> In-Reply-To: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org> (Alexey Dokuchaev's message of "Sat, 26 Mar 2022 01:11:06 GMT") References: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2022-03-26 at 01:11, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > The branch main has been updated by danfe: > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D2b7653e70047152706594137= 3b7f0b9158e33fbd > commit 2b7653e700471527065941373b7f0b9158e33fbd > Author: Alexey Dokuchaev <danfe@FreeBSD.org> > AuthorDate: 2022-03-26 01:10:00 +0000 > Commit: Alexey Dokuchaev <danfe@FreeBSD.org> > CommitDate: 2022-03-26 01:10:00 +0000 > x11-fm/polo: new port had been added (+) > Advanced file manager for Unix-like systems written in Vala. Supports > multiple panes (single, dual, quad) with multiple tabs in each pane. > Supports archive creation, extraction, and browsing. Support for clo= ud > storage; running and managing KVM images, modifying PDF documents and > image files, booting ISO files in KVM, writing ISO files to USB drive= s. > WWW: https://teejee2008.github.io/polo/ <snip> Is there a good reason to install the binaries unstripped? Stripping them reduces the size by about 20% in this case. If there is a good reason, then '5.16.2. Stripping Binaries and Shared Libraries' of the Porter's Handbook, which says "Installed binaries should be stripped." should be clarified. > diff --git a/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-g= tk-theme b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-t= heme > new file mode 100644 > index 000000000000..a174735f961f > --- /dev/null > +++ b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-theme > @@ -0,0 +1,17 @@ > +--- share/polo/files/gtk-theme/install-gtk-theme.orig 2018-08-12 04:41:5= 8 UTC > ++++ share/polo/files/gtk-theme/install-gtk-theme > +@@ -1,4 +1,4 @@ > +-#!/bin/bash > ++#!/bin/sh > +=20 > + gtk_major=3D$( polo-gtk3-helper --major ) > + if [ $? -ne 0 ]; then exit 1; fi > +@@ -11,7 +11,7 @@ DIR=3D"$( cd "$( dirname "$0" )" && pwd )" > + cd $DIR > + if [ $? -ne 0 ]; then exit 1; fi > +=20 > +-if (($gtk_minor =3D=3D 14)) || (($gtk_minor =3D=3D 16)) || (($gtk_minor= =3D=3D 18)) || (($gtk_minor =3D=3D 20)) || (($gtk_minor =3D=3D 22)); then > ++if [ $gtk_minor =3D 14 -o $gtk_minor =3D 16 -o $gtk_minor =3D 18 -o $gt= k_minor =3D 20 -o $gtk_minor =3D 22 ]; then [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ]. See the BUGS section of TEST(1) and https://github.com/koalaman/shellcheck/wiki/SC2166. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmI/FU1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvng6aD/9I7MzsIkLLE7EWNWGFTaMRtHZxUX8/zol8 6uyu++hzVBpPQhPgVh34kJz2tgQNPFanZ1kreY1IxQenFUfaEgeMWE0BdlfbEHQX 1/NGc3JvaiJ11GZnpCyoR4jokaHP3hn6XCPZmHw1KNhj9jBDUO2cy3YaW4vRhi06 4/Qz7aDvqnhklbcgN9/t8Neugbpmy5VUoTaSYIo2pr07NsdRsKyJ4tf84+DiLqhA hs+VoeGFCfNs6eKyd1d6R3/fKq9zz84Xzm7RHQp9HLUdWVwmkETzWudAdAu9FMYY lEthk82YR2UldwDdPr9cjb281C7zs0o3Awt3Lmiismx35mXevR5m8V9M6MwHyxuu eA6okT47XB9Chu7f65knWXNL8GoMOA8Id3+0qfO7zdiBUgyQWQeiWagOdMa1y1MY 1p22YH2D/dnhNGHJbpGlpkXVIgZf9Cnhqfi/orbc9SKOxT7LbHZQoLQfdBCwMFwg xWTBZzMqDAHxY0xWBxwG8P5YU+ot9gNSjgZCT2YX8OplRZOXVdzFc42zjNZUcayW C7Oy4gLVVhiOSMwm8YkT0R9I01E+H7ACwsrK764QscxSY0vFJbptXLBmUi1KXW8p vHO0X5DNfKEynQWk5wrhiVgC0IRnz2wDTYKlfuUSiIvm7IkgrKJPu4DhWJhKA+s0 W7U5jT8D+A== =c9sV -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86fsn46dv6.fsf>