Date: Tue, 29 Oct 2013 23:53:39 +0530 From: "Abhishek [ABK] Kumar" <abhikumar163@gmail.com> To: freebsd-current@freebsd.org Subject: [misc/183407] Routing restart returns non-zero exitcode Message-ID: <CAKijsPPEm-DnjY_kmo9QxGXaj4EvnH0WbsJFhjSos9=hpQB6OA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--001a11333c220a726404e9e552dd Content-Type: text/plain; charset=ISO-8859-1 misc/183407: Routing restart returns non-zero exitcode in case of no extra routing parameter or missing atm/ipx *Environment* FreeBSD h4ck3r.freebsd.org 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 *Description* Current "/etc/rc.d/routing" script is as such it returns non-zero exitcode on restart in very common cases. There are 2 issues in total... Issue#1. It unsets a var and only in case any additional routing options of the provided communication channel (inet, inet6, atm, ipx) is to be turned on, it gets set. It fails for us as we don't have any extra routing options. For now I've patched it not to fail in case of no additional routing options. Do check if any additional routing option is required or not. Issue#2. There is also error in default case of routing start, where it tries to setroute for all (inet, inet6, atm, ipx) modes. Before that it checks if it's present or not and fails for atm and ipx not being present. Since script is resilient enough, the required configuration gets applied. But the exitcode is erroneous which fails our configuration management tools by making them think the run failed itself. *How-To-Repeat* Shall happend for any install. But to be sure install it on a Virtualbox or any virtualization platform (have myself tried it on Xen and VirtualBox). Perform `/etc/rc.d/routing restart ; echo $?` This will show a non-zero exitcode for routing service restart action. *Fix:* attached patch file http://www.freebsd.org/cgi/query-pr.cgi?pr=183407 ~ Regards, Abhishek Kumar http://twitter.com/abionic http://github.com/abhishekkr http://abhishekkr.wordpress.com ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~=ABK=~ --001a11333c220a726404e9e552dd Content-Type: text/plain; charset=US-ASCII; name="freebsd-183407-routing-patch.txt" Content-Disposition: attachment; filename="freebsd-183407-routing-patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hndgq3jv0 LS0tIHJvdXRpbmctaGVhZAkyMDEzLTEwLTI4IDIxOjA2OjE1LjQzNDQ5NTI0MSArMDUzMAorKysg cm91dGluZy1oZWFkLXBhdGNoZWQJMjAxMy0xMC0yOCAyMToxMDoxNC44MDc4MzYwMDAgKzA1MzAK QEAgLTIxLDEyICsyMSwyMSBAQAogCiBST1VURV9DTUQ9Ii9zYmluL3JvdXRlIgogCitnZXRfY29t bXVuaWNhdGlvbl9jaGFubmVscygpeworCWZvciBfYSBpbiBpbmV0IGluZXQ2IGF0bSBpcHg7IGRv CisJCWlmIGFmZXhpc3RzICRfYTsgdGhlbgorCQkJY29tbV9jaGFubmVsPSIke2NvbW1fY2hhbm5l bH0gJF9hIgorCQlmaQorCWRvbmUKK30KKwogcm91dGluZ19zdGFydCgpCiB7CiAJbG9jYWwgX2Nt ZCBfYWYgX2lmIF9hCiAJX2NtZD0kMQogCV9hZj0kMgogCV9pZj0kMworCWdldF9jb21tdW5pY2F0 aW9uX2NoYW5uZWxzCiAKIAljYXNlICRfaWYgaW4KIAkiInxbQWFdW0xsXVtMbF18W0FhXVtObl1b WXldKQlfaWY9IiIgOzsKQEAgLTQxLDcgKzUwLDcgQEAKIAkJZmkKIAkJOzsKIAkiInxbQWFdW0xs XVtMbF18W0FhXVtObl1bWXldKQotCQlmb3IgX2EgaW4gaW5ldCBpbmV0NiBpcHggYXRtOyBkbwor CQlmb3IgX2EgaW4gJGNvbW1fY2hhbm5lbDsgZG8KIAkJCWFmZXhpc3RzICRfYSAmJiBzZXRyb3V0 ZXMgJF9jbWQgJF9hICRfaWYKIAkJZG9uZQogCQk7OwpAQCAtNTYsNiArNjUsNyBAQAogCWxvY2Fs IF9hZiBfaWYgX2EKIAlfYWY9JDEKIAlfaWY9JDIKKwlnZXRfY29tbXVuaWNhdGlvbl9jaGFubmVs cwogCiAJY2FzZSAkX2lmIGluCiAJIiJ8W0FhXVtMbF1bTGxdfFtBYV1bTm5dW1l5XSkJX2lmPSIi IDs7CkBAIC03NCw3ICs4NCw3IEBACiAJCWZpCiAJCTs7CiAJIiJ8W0FhXVtMbF1bTGxdfFtBYV1b Tm5dW1l5XSkKLQkJZm9yIF9hIGluIGluZXQgaW5ldDYgaXB4IGF0bTsgZG8KKwkJZm9yIF9hIGlu ICRjb21tX2NoYW5uZWw7IGRvCiAJCQlhZmV4aXN0cyAkX2EgfHwgY29udGludWUKIAkJCWV2YWwg c3RhdGljXyR7X2F9IGRlbGV0ZSAkX2lmCiAJCQkjIFdoZW4gJF9pZiBpcyBzcGVjaWZpZWQsIGRv IG5vdCBmbHVzaCByb3V0ZXMuCkBAIC0zMDYsNyArMzE2LDkgQEAKIG9wdGlvbnNfaW5ldCgpCiB7 CiAJX3JvcHRzX2luaXRkb25lPQorCV9hbGxfZmFsc2VfY2hlY2t5ZXNubz10cnVlCiAJaWYgY2hl Y2t5ZXNubyBpY21wX2JtY2FzdGVjaG87IHRoZW4KKwkJX2FsbF9mYWxzZV9jaGVja3llc25vPWZh bHNlCiAJCXJvcHRzX2luaXQgaW5ldAogCQllY2hvIC1uICcgYnJvYWRjYXN0IHBpbmcgcmVzcG9u c2VzPVlFUycKIAkJJHtTWVNDVEx9IG5ldC5pbmV0LmljbXAuYm1jYXN0ZWNobz0xID4gL2Rldi9u dWxsCkBAIC0zMTUsNiArMzI3LDcgQEAKIAlmaQogCiAJaWYgY2hlY2t5ZXNubyBpY21wX2Ryb3Bf cmVkaXJlY3Q7IHRoZW4KKwkJX2FsbF9mYWxzZV9jaGVja3llc25vPWZhbHNlCiAJCXJvcHRzX2lu aXQgaW5ldAogCQllY2hvIC1uICcgaWdub3JlIElDTVAgcmVkaXJlY3Q9WUVTJwogCQkke1NZU0NU TH0gbmV0LmluZXQuaWNtcC5kcm9wX3JlZGlyZWN0PTEgPiAvZGV2L251bGwKQEAgLTMyMyw2ICsz MzYsNyBAQAogCWZpCiAKIAlpZiBjaGVja3llc25vIGljbXBfbG9nX3JlZGlyZWN0OyB0aGVuCisJ CV9hbGxfZmFsc2VfY2hlY2t5ZXNubz1mYWxzZQogCQlyb3B0c19pbml0IGluZXQKIAkJZWNobyAt biAnIGxvZyBJQ01QIHJlZGlyZWN0PVlFUycKIAkJJHtTWVNDVEx9IG5ldC5pbmV0LmljbXAubG9n X3JlZGlyZWN0PTEgPiAvZGV2L251bGwKQEAgLTMzMSw2ICszNDUsNyBAQAogCWZpCiAKIAlpZiBj aGVja3llc25vIGdhdGV3YXlfZW5hYmxlOyB0aGVuCisJCV9hbGxfZmFsc2VfY2hlY2t5ZXNubz1m YWxzZQogCQlyb3B0c19pbml0IGluZXQKIAkJZWNobyAtbiAnIGdhdGV3YXk9WUVTJwogCQkke1NZ U0NUTH0gbmV0LmluZXQuaXAuZm9yd2FyZGluZz0xID4gL2Rldi9udWxsCkBAIC0zMzksNiArMzU0 LDcgQEAKIAlmaQogCiAJaWYgY2hlY2t5ZXNubyBmb3J3YXJkX3NvdXJjZXJvdXRlOyB0aGVuCisJ CV9hbGxfZmFsc2VfY2hlY2t5ZXNubz1mYWxzZQogCQlyb3B0c19pbml0IGluZXQKIAkJZWNobyAt biAnIGRvIHNvdXJjZSByb3V0aW5nPVlFUycKIAkJJHtTWVNDVEx9IG5ldC5pbmV0LmlwLnNvdXJj ZXJvdXRlPTEgPiAvZGV2L251bGwKQEAgLTM0Nyw2ICszNjMsNyBAQAogCWZpCiAKIAlpZiBjaGVj a3llc25vIGFjY2VwdF9zb3VyY2Vyb3V0ZTsgdGhlbgorCQlfYWxsX2ZhbHNlX2NoZWNreWVzbm89 ZmFsc2UKIAkJcm9wdHNfaW5pdCBpbmV0CiAJCWVjaG8gLW4gJyBhY2NlcHQgc291cmNlIHJvdXRp bmc9WUVTJwogCQkke1NZU0NUTH0gbmV0LmluZXQuaXAuYWNjZXB0X3NvdXJjZXJvdXRlPTEgPiAv ZGV2L251bGwKQEAgLTM1NSw2ICszNzIsNyBAQAogCWZpCiAKIAlpZiBjaGVja3llc25vIGFycHBy b3h5X2FsbDsgdGhlbgorCQlfYWxsX2ZhbHNlX2NoZWNreWVzbm89ZmFsc2UKIAkJcm9wdHNfaW5p dCBpbmV0CiAJCWVjaG8gLW4gJyBBUlAgcHJveHlhbGw9WUVTJwogCQkke1NZU0NUTH0gbmV0Lmxp bmsuZXRoZXIuaW5ldC5wcm94eWFsbD0xID4gL2Rldi9udWxsCkBAIC0zNjIsMTQgKzM4MCwxNiBA QAogCQkke1NZU0NUTH0gbmV0LmxpbmsuZXRoZXIuaW5ldC5wcm94eWFsbD0wID4gL2Rldi9udWxs CiAJZmkKIAotCVsgLW4gIiR7X3JvcHRzX2luaXRkb25lfSIgXSAmJiBlY2hvICcuJworCVsgLW4g IiR7X3JvcHRzX2luaXRkb25lfSIgXSB8fCAkX2FsbF9mYWxzZV9jaGVja3llc25vCiB9CiAKIG9w dGlvbnNfaW5ldDYoKQogewogCV9yb3B0c19pbml0ZG9uZT0KKwlfYWxsX2ZhbHNlX2NoZWNreWVz bm89dHJ1ZQogCiAJaWYgY2hlY2t5ZXNubyBpcHY2X2dhdGV3YXlfZW5hYmxlOyB0aGVuCisJCV9h bGxfZmFsc2VfY2hlY2t5ZXNubz1mYWxzZQogCQlyb3B0c19pbml0IGluZXQ2CiAJCWVjaG8gLW4g JyBnYXRld2F5PVlFUycKIAkJJHtTWVNDVEx9IG5ldC5pbmV0Ni5pcDYuZm9yd2FyZGluZz0xID4g L2Rldi9udWxsCkBAIC0zNzcsMjEgKzM5NywyNCBAQAogCQkke1NZU0NUTH0gbmV0LmluZXQ2Lmlw Ni5mb3J3YXJkaW5nPTAgPiAvZGV2L251bGwKIAlmaQogCi0JWyAtbiAiJHtfcm9wdHNfaW5pdGRv bmV9IiBdICYmIGVjaG8gJy4nCisJWyAtbiAiJHtfcm9wdHNfaW5pdGRvbmV9IiBdIHx8ICRfYWxs X2ZhbHNlX2NoZWNreWVzbm8KIH0KIAogb3B0aW9uc19hdG0oKQogewogCV9yb3B0c19pbml0ZG9u ZT0KKwlfYWxsX2ZhbHNlX2NoZWNreWVzbm89dHJ1ZQogCi0JWyAtbiAiJHtfcm9wdHNfaW5pdGRv bmV9IiBdICYmIGVjaG8gJy4nCisJWyAtbiAiJHtfcm9wdHNfaW5pdGRvbmV9IiBdIHx8ICRfYWxs X2ZhbHNlX2NoZWNreWVzbm8KIH0KIAogb3B0aW9uc19pcHgoKQogewogCV9yb3B0c19pbml0ZG9u ZT0KKwlfYWxsX2ZhbHNlX2NoZWNreWVzbm89dHJ1ZQogCiAJaWYgY2hlY2t5ZXNubyBpcHhnYXRl d2F5X2VuYWJsZTsgdGhlbgorCQlfYWxsX2ZhbHNlX2NoZWNreWVzbm89ZmFsc2UKIAkJcm9wdHNf aW5pdCBpcHgKIAkJZWNobyAtbiAnIGdhdGV3YXk9WUVTJwogCQkke1NZU0NUTH0gbmV0LmlweC5p cHguaXB4Zm9yd2FyZGluZz0xID4gL2Rldi9udWxsCkBAIC0zOTksNyArNDIyLDcgQEAKIAkJJHtT WVNDVEx9IG5ldC5pcHguaXB4LmlweGZvcndhcmRpbmc9MCA+IC9kZXYvbnVsbAogCWZpCiAKLQlb IC1uICIke19yb3B0c19pbml0ZG9uZX0iIF0gJiYgZWNobyAnLicKKwlbIC1uICIke19yb3B0c19p bml0ZG9uZX0iIF0gfHwgJF9hbGxfZmFsc2VfY2hlY2t5ZXNubwogfQogCiBsb2FkX3JjX2NvbmZp ZyAkbmFtZQ== --001a11333c220a726404e9e552dd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKijsPPEm-DnjY_kmo9QxGXaj4EvnH0WbsJFhjSos9=hpQB6OA>